Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove C++20 Patches from ReactCommon Files #12195

Closed
chiaramooney opened this issue Sep 29, 2023 · 4 comments
Closed

Remove C++20 Patches from ReactCommon Files #12195

chiaramooney opened this issue Sep 29, 2023 · 4 comments

Comments

@chiaramooney
Copy link
Contributor

chiaramooney commented Sep 29, 2023

Remove patches needed because RN is on C++20 and we use a lower version. Patches were made to ShadowTree.cpp, NumericBitfield.cpp, Config.h, LayoutResults.h, UIMangerBinding.cpp, and Node.h.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Sep 29, 2023
@chrisglein chrisglein added Deforking Area: Build Infrastructure and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Oct 2, 2023
@chrisglein
Copy link
Member

chrisglein commented Oct 2, 2023

Related:

Need to make a decision on whether we update this for 0.73. Doesn't seem like there's a reason for us to not match core and use this latest. Just need to make sure any customers who can't make that move have a clear path.

@chrisglein chrisglein added this to the 0.73 milestone Oct 2, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Oct 3, 2023
@jonthysell jonthysell modified the milestones: 0.73, Next, 0.74 Nov 7, 2023
@chrisglein chrisglein assigned chiaramooney and unassigned jonthysell Dec 6, 2023
@TatianaKapos
Copy link
Contributor

Added RawPropsParser.cpp and propsConversion.h from the PR https://github.com/facebook/react-native/pull/41149/files

@chrisglein chrisglein added enhancement and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Feb 13, 2024
@chrisglein chrisglein modified the milestones: 0.74, Next Feb 29, 2024
@chrisglein
Copy link
Member

@chiaramooney Can you check the forking status of these files given the integration payload for the past couple months?

@TatianaKapos
Copy link
Contributor

Closing, check with main and these files are unforked :)

  • ShadowTree.cpp
  • NumericBitfield.cpp
  • Config.h
  • LayoutResults.h
  • UIMangerBinding.cpp
  • Node.h
  • RawPropsParser.cpp
  • propsConversion.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants