Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Text Data to Composition Tree Dump Contents #13237

Open
Tracked by #11422
chiaramooney opened this issue May 14, 2024 · 2 comments
Open
Tracked by #11422

Add Text Data to Composition Tree Dump Contents #13237

chiaramooney opened this issue May 14, 2024 · 2 comments
Assignees
@chiaramooney
Labels
Area: Fabric Support Facebook Fabric Area: Tests Area: Text enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Milestone
Backlog

Comments

@chiaramooney
Copy link
Contributor

chiaramooney commented May 14, 2024 •
edited

Currently we have Composition Tree Dump tests which dump some of the contents of a components Composition tree into a JSON object. We should add text data to the JSON dumps, so we have information on text value and styling included in our checks for visual regressions.
@chiaramooney chiaramooney mentioned this issue May 14, 2024
Open
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 14, 2024
@chiaramooney chiaramooney self-assigned this May 15, 2024
@jonthysell jonthysell added this to the Backlog milestone May 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label May 16, 2024
@jonthysell
Copy link
Contributor

We should also have rendering verification tests (i.e. screenshot comparisons).

@jonthysell jonthysell removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 16, 2024
@jonthysell
Copy link
Contributor

We should also decide what we capture in the text comparison (raw text, styling, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chiaramooney chiaramooney

Labels
Area: Fabric Support Facebook Fabric Area: Tests Area: Text enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
RNW New Architecture
Status: No status
Milestone
Backlog
Development

No branches or pull requests
2 participants
@jonthysell @chiaramooney