Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change our new arch cpp-lib template to align with the RN "golden" template #13250

Open
jonthysell opened this issue May 20, 2024 · 0 comments
Open

Change our new arch cpp-lib template to align with the RN "golden" template #13250

jonthysell opened this issue May 20, 2024 · 0 comments
Labels
enhancement Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Old Architecture Broad category for issues that apply to the RN "old" architecture of Cxx Modules + Paper

Comments

@jonthysell
Copy link
Contributor

Summary

There's a (still in progress at the time of opening this) RFC to create a specific official "golden" template for RN libraries, being discussed here: react-native-community/discussions-and-proposals#721

Specifics may change, but so far it looks like:

  • New and Old Arch support
  • Includes both a native module and a native view component
  • Uses TypeScript
  • Android/iOS provided by Java and ObjC

You can see the details here: https://github.com/react-native-community/discussions-and-proposals/pull/721/files#diff-3e529b09f72e10925002030c7234cea4ff1fcfff33aea495328c58e8b4518955

Motivation

When the output of this RFC becomes the official template, we'll want to pivot onto it for our template, because we can't possibly support every variation of libraries that have evolved in the community, we'll build on the standard and let others standardize their code or adapt ours.

Basic Example

No response

Open Questions

No response
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 20, 2024
@jonthysell jonthysell added Old Architecture Broad category for issues that apply to the RN "old" architecture of Cxx Modules + Paper New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels May 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Old Architecture Broad category for issues that apply to the RN "old" architecture of Cxx Modules + Paper
Projects
RNW New Architecture
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonthysell