Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support react-native-camera on RNW vNext #2550

Closed
harishkrishnav opened this issue May 31, 2019 · 10 comments
Closed

Support react-native-camera on RNW vNext #2550

harishkrishnav opened this issue May 31, 2019 · 10 comments
Assignees
@ddalp
Labels
Extensions Tracks issues against community modules and extensions must-have p1 Needs: PM Design New feature or request
Projects
Extensions: Developer Experience for ... Community Module Requests
Milestone
0.62 (M5)

Comments

@harishkrishnav
Copy link

harishkrishnav commented May 31, 2019 •
edited
Loading

I saw the presentation made at //Build and also some issues from years ago about camera support. Does vnext now have the functionality?
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 31, 2019
@harishkrishnav harishkrishnav changed the title Access camera camera support Jun 1, 2019
@harinikmsft harinikmsft added Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jun 12, 2019
@harinikmsft
Copy link
Contributor

Hello -

We are planning to add windows vnext support for the react-native-cameraroll module in Milestone 3. Is this the one you are referring to?

@harinikmsft harinikmsft added the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Jun 12, 2019
@harishkrishnav
Copy link
Author

Yes. Thank you for the response.

@ghost ghost added Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) and removed Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) labels Jun 17, 2019
@harinikmsft harinikmsft removed Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jun 17, 2019
@harinikmsft harinikmsft added this to the vNext Milestone 3 milestone Jun 17, 2019
@harinikmsft
Copy link
Contributor

Thanks. Moving this to Milestone 3.

@harinikmsft harinikmsft changed the title camera support Add Windows support for react-native-cameraroll module Jun 17, 2019
@harinikmsft harinikmsft added the Needs: PM Design New feature or request label Jul 1, 2019
@chrisglein chrisglein added the Extensions Tracks issues against community modules and extensions label Aug 10, 2019
@chrisglein
Copy link
Member

@harinikmsft is this on our short list of first line extensions for M3 or this okay to do in M4?

@harinikmsft
Copy link
Contributor

This can be done in Milestone 4. We will need to first complete the view manager story and then add support this (now community) module.

@chrisglein
Copy link
Member

Moving back to M3 as we'll want to use this as a test case for native modules.

@chrisglein chrisglein mentioned this issue Sep 9, 2019
Closed
@harinikmsft harinikmsft assigned stmoy and unassigned harinikmsft Oct 3, 2019
@harinikmsft
Copy link
Contributor

@stmoy - you can use this issue for the validation of custom view manager story.

@chrisglein chrisglein assigned ddalp and unassigned jonthysell Oct 15, 2019
@chrisglein chrisglein mentioned this issue Oct 16, 2019
Closed
@stmoy
Copy link
Contributor

stmoy commented Oct 17, 2019

The original intent of this issue was to support camera. CameraRoll probably isn't the right module for that - we want Camera instead: react-native-camera.

Renaming. Please leave a comment if you disagree. @harishkrishnav

@stmoy stmoy changed the title Add Windows support for react-native-cameraroll module Add Windows support for react-native-camera module Oct 17, 2019
@stmoy stmoy changed the title Add Windows support for react-native-camera module Support react-native-camera on RNW vNext Nov 11, 2019
@stmoy stmoy mentioned this issue Jan 11, 2020
Closed
@stmoy stmoy removed their assignment Jan 29, 2020
@ddalp
Copy link
Contributor

ddalp commented Mar 11, 2020

React Native Camera native module is checked in.

@ddalp ddalp closed this as completed Mar 11, 2020
@stmoy stmoy moved this from In progress/Up Next to Complete in Community Module Requests Mar 17, 2020
@chrisglein
Copy link
Member

Providing link to PR to help people looking back over the process of adding Windows support to existing native modules: react-native-camera/react-native-camera#2723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddalp ddalp

Labels
Extensions Tracks issues against community modules and extensions must-have p1 Needs: PM Design New feature or request
Projects
Community Module Requests
  
Complete
Extensions: Developer Experience for ...
  
Done
Milestone
0.62 (M5)
Development

No branches or pull requests
6 participants
@harishkrishnav @jonthysell @harinikmsft @stmoy @chrisglein @ddalp