Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yoga does not consider Styles when computing Width/Height of a XAML control #8213

Closed
asklar opened this issue Jul 11, 2021 · 2 comments
Closed
Labels
Area: Layout bug Recommend: Close Issue Recommend that issue should be closed
Milestone

Comments

@asklar
Copy link
Member

asklar commented Jul 11, 2021

See asklar/react-native-xaml#96

The default width for <AppBarButton> is coming from a Style. However, Yoga will just ask the control for its width who just gives back the "actual size", for example, 17px. However, AppBarButton has a default Style with a width of 68px.

In a C# UWP XAML app:

image

image


In a RNW app:

image

image

@asklar asklar added the bug label Jul 11, 2021
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 11, 2021
@chrisglein chrisglein added Area: Layout and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jul 12, 2021
@chrisglein chrisglein added this to the Backlog milestone Jul 12, 2021
@chrisglein
Copy link
Member

The XAML Style is being clobbered by Yoga. This is part of a larger class of issues with the way the two layout systems are overlapping. See linked areas by label Area: Layout.

@chiaramooney
Copy link
Contributor

Not something we plan to address on the Paper renderer as we move towards Fabric.
Fabric will not use XAML for the fundamentals of accessibility here, so this isn't applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Layout bug Recommend: Close Issue Recommend that issue should be closed
Projects
None yet
Development

No branches or pull requests

4 participants