Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DebuggerBreakOnNextLine In Hermes #9358

Open
Tracked by #157
NickGerleman opened this issue Jan 10, 2022 · 4 comments
Open
Tracked by #157

Support DebuggerBreakOnNextLine In Hermes #9358

NickGerleman opened this issue Jan 10, 2022 · 4 comments

Comments

@NickGerleman
Copy link
Collaborator

We have an instance setting, DebuggerBreakOnNextLine, which allows debugging the boot process. It is wired to Chakra and V8, but doesn't seem to effect Hermes. From feedback in teams, folks would find this functionality to be useful.

@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jan 10, 2022
@chrisglein
Copy link
Member

@NickGerleman Is this supported by Hermes Windows itself and we need to hook it up in RNW? Or is it also lacking in Hermes Windows (in which case we need another issue on that repo as well).

@chrisglein chrisglein added Area: Developer Experience Area: JavaScript Engine enhancement and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jan 13, 2022
@chrisglein chrisglein added this to the 0.69 milestone Jan 13, 2022
@chrisglein
Copy link
Member

Timing here depends a lot on when the shift to Hermes as default happens. We also have gaps in postmortem debugging, for example. This one here seems pretty fundamental as well for good quality of life.

@jonthysell
Copy link
Contributor

@TatianaKapos Do you think this will make 0.69 or should it be moved to 0.70?

@TatianaKapos
Copy link
Contributor

@jonthysell Moved it to .70!

@TatianaKapos TatianaKapos modified the milestones: 0.69, 0.70 May 9, 2022
@chrisglein chrisglein modified the milestones: 0.70, Backlog Aug 16, 2022
@TatianaKapos TatianaKapos added the Recommend: Backlog Recommend that issue should be given Backlog milestone. label Aug 31, 2023
@chiaramooney chiaramooney removed the Recommend: Backlog Recommend that issue should be given Backlog milestone. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants