Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove early stopping round from lightgbm example notebook #1620

Merged
merged 4 commits into from Jan 21, 2022

Conversation

imatiach-msft
Copy link
Collaborator

Description

remove early stopping round from lightgbm example notebook since it isn't used

Related Issues

This is a related issue to this minor notebook patch:
#1615

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

remove early stopping round from lightgbm example notebook since it isn't used
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@imatiach-msft
Copy link
Collaborator Author

weird, the build seems to be failing. did I make a mistake?

@anargyri
Copy link
Collaborator

weird, the build seems to be failing. did I make a mistake?

No, this happens frequently I am afraid. The GitHub host has low resources. I will rerun the jobs.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great Ilia!

@miguelgfierro
Copy link
Collaborator

weird, the build seems to be failing. did I make a mistake?

it's because the default machines we have in GitHub actions have low memory. However, @pradnyeshjoshi is going to start a new set of tests using AzureML #995 that hopefully eliminated this problem and reduced massively the test time

@miguelgfierro miguelgfierro merged commit ed14802 into staging Jan 21, 2022
@miguelgfierro miguelgfierro deleted the remove-stopping-round branch January 21, 2022 08:45
@imatiach-msft
Copy link
Collaborator Author

thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants