Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwrite older test file in NCF deep dive to avoid bug #1674

Merged
merged 1 commit into from Mar 15, 2022
Merged

Overwrite older test file in NCF deep dive to avoid bug #1674

merged 1 commit into from Mar 15, 2022

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Mar 14, 2022 •
edited

Description

Files from previous tests in NCF notebook remain and cause test failures. Test file should be overwritten.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

miguelgfierro
miguelgfierro approved these changes Mar 15, 2022
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguelgfierro miguelgfierro merged commit 6390ca8 into staging Mar 15, 2022
@miguelgfierro miguelgfierro deleted the andreas/ncf_bug branch March 15, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anargyri @miguelgfierro