Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce iterations of W&D to reduce the integration tests time #1698

Merged
merged 1 commit into from Apr 9, 2022

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented Apr 7, 2022

Description

FYI @pradnyeshjoshi

Test time: 1457.14s

Related Issues

#1695

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@codecov-commenter
Copy link

Codecov Report

Merging #1698 (3a7c9fc) into staging (b7d79ab) will increase coverage by 23.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           staging    #1698       +/-   ##
============================================
+ Coverage     0.00%   23.22%   +23.22%     
============================================
  Files           88       88               
  Lines         9121     9121               
============================================
+ Hits             0     2118     +2118     
- Misses           0     7003     +7003     
Flag Coverage Δ
nightly ?
pr-gate 23.22% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/datasets/mind.py 0.00% <0.00%> (ø)
recommenders/datasets/movielens.py 66.37% <0.00%> (+66.37%) ⬆️
recommenders/datasets/download_utils.py 90.00% <0.00%> (+90.00%) ⬆️
recommenders/evaluation/spark_evaluation.py 86.66% <0.00%> (+86.66%) ⬆️
recommenders/models/newsrec/io/mind_iterator.py 0.00% <0.00%> (ø)
recommenders/models/newsrec/models/base_model.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7d79ab...3a7c9fc. Read the comment docs.

@miguelgfierro miguelgfierro merged commit addbb79 into staging Apr 9, 2022
@miguelgfierro miguelgfierro deleted the miguelgfierro-patch-1 branch April 9, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants