Added time performance tests #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuyangKe
requested review from
miguelgfierro,
gramhagen,
anargyri,
loomlike and
wutaomsft
as code owners
| # The thresholds are calculated by MEAN + 5 * STANDARD DEVIATION. | ||
|
|
||
|
|
||
| def test_merge_rating(rating_true, rating_pred): |
There was a problem hiding this comment.
@pradnyeshjoshi Chuyang needs to add these tests to some of the test groups. I'm thinking that we might want to create a small tutorial to help developers add tests. What do you think?
simonzhaoms
suggested changes
Jul 1, 2022
added 4 commits
July 1, 2022 10:39
…removed unused lines, updated benchmark results
…nto chuyang/time_test
simonzhaoms
approved these changes
Jul 6, 2022
tests/unit/recommenders/evaluation/test_python_evaluation_time_performance.py
Outdated
Show resolved
Hide resolved
miguelgfierro
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added time performance tests for rating and ranking metrics.
The time baselines are provided to ensure that the metrics can be computed in a reasonable amount of time on the same testing server. Currently the thresholds are set as MEAN + 5 * STANDARD DEVIATION based on benchmark results.
List of testing functions:
Related Issues
Related to issue #1750
Checklist:
staging branchand not tomain branch.