Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path filter for unit tests #1791

Merged
merged 3 commits into from Jul 19, 2022

Conversation

simonzhaoms
Copy link
Contributor

@simonzhaoms simonzhaoms commented Jul 18, 2022

Description

This PR adds a path filter to check if any changes to the unit tests code, thus the unit tests will not run if only docs are changed. The paths to trigger the unit tests include (Please confirm @miguelgfierro @pradnyeshjoshi):

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro
Copy link
Collaborator

it seems there are some conflicts. Simon one question, how can we check that this is effective? do you need the code to be in staging or main? for example, if you change a markdown now, are the tests not triggered?

@simonzhaoms
Copy link
Contributor Author

it seems there are some conflicts. Simon one question, how can we check that this is effective? do you need the code to be in staging or main? for example, if you change a markdown now, are the tests not triggered?

I forgot you just merged the PR. No wonder all unit tests are triggered.

@miguelgfierro
Copy link
Collaborator

@simonzhaoms have you tried this code? do you know if it is not triggered if there is a change in a readme?

@simonzhaoms simonzhaoms marked this pull request as ready for review July 19, 2022 08:25
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's see if this works

@miguelgfierro miguelgfierro merged commit 82febff into staging Jul 19, 2022
@miguelgfierro miguelgfierro deleted the simonz/2022-07-18/unit-tests-file-paths branch July 19, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants