Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD #20

Closed
omiossec opened this issue Jul 8, 2019 · 3 comments
Closed

CI/CD #20

omiossec opened this issue Jul 8, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@omiossec
Copy link
Contributor

omiossec commented Jul 8, 2019

I have few remarks regarding how the module is tested and build

I did not see any build or CD information in the module. There is no badge, no build process.
If you look at the final product, the one you get from the PowerShell Gallery, include the same folder as the GitHub repos. This include the source, the .git, the .vscode and the images folders, readme.md and the test files.

My suggestions:

  • Create a build process (Azure DevOps ? but perhaps it exists elsewhere)
    Include a module creation with one psm1 file and a class folder for type.ps1
  • Test the newly created module (test the module and the scripts)
  • Include a badge on the readme page
  • Automate module publishing
@chriskuech chriskuech self-assigned this Jul 9, 2019
@chriskuech
Copy link
Contributor

chriskuech commented Jul 9, 2019

I am working (slowly) on CI/CD for this (and simultaneously other) PowerShell module repos. I also just created #22 for testing the psm1.

one psm1 file and a class folder for type.ps1

I see value in removing the development files (.git, .vscode, imgs, etc), but are you saying all the script files (except types.ps1) should be merged into a single psm1? If so, what is that value of that over dot-sourced scripts?

@chriskuech chriskuech added the enhancement New feature or request label Jul 9, 2019
@omiossec
Copy link
Contributor Author

Hi
The values of a unique psm1 file are

@chriskuech chriskuech changed the title Suggestions about the module CI/CD Jul 26, 2019
@chriskuech
Copy link
Contributor

GitHub Actions landed, so I finally added CI/CD. I don't build a psm1, but we are no longer publishing redundant dev files (though I have yet to release a new module version). Integration test enforcement and improvement is being tracked in another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants