Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable sensitive data logging in restler (e.g. full network log) #73

Closed
rifiles opened this issue Nov 19, 2020 · 4 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@rifiles
Copy link
Collaborator

rifiles commented Nov 19, 2020

Add the ability to disable logging in restler that could lead to leaked personal or sensitive information. I.e. request/response data sent to and received from the server.

@rifiles rifiles self-assigned this Nov 19, 2020
@marina-p
Copy link
Contributor

To clarify further: this option was proposed for the use case where the user has a RESTler setup where --logsUploadRootDirPath is set, and wants to avoid storing raw network logs. This primarily applies for cases where RESTler may not be filtering authentication information (e.g. if added in custom headers).

However, wouldn't any bug bucket contain a replay log with the sent request, which would contain the above data?

@PatGod
Copy link
Contributor

PatGod commented Nov 19, 2020

Yes, this work item sounds ill-defined. RESTler and the Swagger spec define request going in and the service under test defines what is contained in responses. The RESTler user is already in full control of where to store (and whether to keep) network logs. (And telemetry does not include any network traffic.) So what is this item about? Please clarify (possibly with a clear scenario or example). Otherwise, I suggest to close this item.

@rifiles
Copy link
Collaborator Author

rifiles commented Nov 19, 2020

To clarify further: this option was proposed for the use case where the user has a RESTler setup where --logsUploadRootDirPath is set, and wants to avoid storing raw network logs. This primarily applies for cases where RESTler may not be filtering authentication information (e.g. if added in custom headers).

However, wouldn't any bug bucket contain a replay log with the sent request, which would contain the above data?

The replay log does indeed contain this data, however the creation of the log could be disabled while still performing the replay, if desired.

@marina-p
Copy link
Contributor

Closing this as out-of-scope for RESTler. Such clean-up/log management can be done by the agent or user that invokes RESTler.

@marina-p marina-p added the wontfix This will not be worked on label Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants