Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement inbound PPv2 #11

Open
analogrelay opened this issue Mar 12, 2020 · 2 comments
Open

Implement inbound PPv2 #11

analogrelay opened this issue Mar 12, 2020 · 2 comments
Labels
Type: Enhancement New feature or request
Milestone

Comments

@analogrelay
Copy link
Contributor

https://www.haproxy.org/download/1.8/doc/proxy-protocol.txt

This is a proxy forwarder protocol primary used by layer 4 proxies to forward information about the original client such as their IP. It does so by pre-pending the connection stream with a text or binary formatted blob of data. It's more efficient than adding X-Forwarded-For and similar headers to every request.

In Kestrel this would be implemented as a connection middleware. We helped an internal team build this middleware already and they're using it with an existing azure network services that sends that data.

I'll file a separate issue for outbound support as it would need to integrate with HttpClient.

@analogrelay
Copy link
Contributor Author

Same as #12, this feels like a post-1.0 thing to me, unless we know of partners asking for it.

@analogrelay analogrelay added this to the Backlog milestone Apr 8, 2020
@Tratcher
Copy link
Member

See aspnet/AspLabs#294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants