Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add microbenchmarks #223

Closed
halter73 opened this issue Jun 2, 2020 · 1 comment
Closed

Add microbenchmarks #223

halter73 opened this issue Jun 2, 2020 · 1 comment
Labels
Type: Task A task that needs to be completed.
Milestone
YARP 1.0.0

Comments

@halter73
Copy link
Member

halter73 commented Jun 2, 2020

We should add microbenchmarks for key methods like ProxyInvokerMiddleware.Invoke(), LoadBalancingMiddleware.Invoke(), LoadBalancer.PickDestination(), etc. using https://github.com/dotnet/BenchmarkDotNet.

This provides a benefit over end-to-end benchmarks since microbenchmarks can more reliably measure smaller performance gains or losses in the components they measure which can add up over time.
@halter73 halter73 added the Type: Task A task that needs to be completed. label Jun 2, 2020
@halter73 halter73 self-assigned this Jun 2, 2020
@karelz karelz added this to the 1.0.0 milestone Jun 2, 2020
@karelz karelz added this to Unscheduled in YARP Planning via automation Jun 2, 2020
@karelz karelz moved this from Unscheduled to 1.0 Backlog in YARP Planning Jun 2, 2020
@samsp-msft samsp-msft mentioned this issue Oct 21, 2020
Closed
5 tasks
@karelz
Copy link
Member

karelz commented Mar 29, 2021

Triage: We should have it for a few things when they show up on the profile. Not needed now.

@karelz karelz closed this as completed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Task A task that needs to be completed.
Projects
None yet
Milestone
YARP 1.0.0
Development

No branches or pull requests
2 participants
@halter73 @karelz