Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotContains match modes for Header and QueryParameters incorrect for missing/empty values #2260

Closed
evmurphy opened this issue Sep 25, 2023 · 0 comments · Fixed by #2258
Closed

NotContains match modes for Header and QueryParameters incorrect for missing/empty values #2260

evmurphy opened this issue Sep 25, 2023 · 0 comments · Fixed by #2258
Labels
Type: Bug Something isn't working

Comments

@evmurphy
Copy link
Contributor

evmurphy commented Sep 25, 2023 •
edited

Currently the NotContains mode for both Header and QueryParameter match types do not match correctly when the value of the header/query is empty or if the key does not exist entirely.

The "CurrentMatch" column below shows YARP's current match result while the "ExpectedMatch" column shows the expected match result.

Type Mode RequestKey RequestValue CurrentMatch ExpectedMatch
Header/QueryParam NotContains None - No Yes
Header/QueryParam NotContains Exists Empty No Yes
Header/QueryParam NotContains Exists NonEmpty No No
@evmurphy evmurphy added the Type: Bug Something isn't working label Sep 25, 2023
@evmurphy evmurphy mentioned this issue Sep 25, 2023
Merged
@evmurphy evmurphy changed the title NotExists and NotContains match modes for Header and QueryParameters incorrect for missing/empty values NotContains match modes for Header and QueryParameters incorrect for missing/empty values Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@evmurphy