Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy configuration is extensible for custom metadata on routes, destinations etc #485

Closed
alnikola opened this issue Oct 22, 2020 · 3 comments
Labels
Priority:1 Used for divisional .NET planning Type: Enhancement New feature or request Type: Idea This issue is a high-level idea for discussion. User Story Used for divisional .NET planning
Milestone

Comments

@alnikola
Copy link
Contributor

There are several *Options types specifying parameters of different providers and policies like CookieSessionAffinityProviderOptions, ConsecutiveFailuresHealthPolicyOptions, TransportFailureRateHealthPolicyOptions etc. In the essence, they are part of the YARP configuration, but currently it's not possible to define them through the generic config provider mechanism. They can be set and changed through code only. There are some ad hoc workarounds to this issue created for some scenarios (e.g. health check policies), but there is a solid need for a well designed *Options configuration mechanism.

We should design and implement a proper *Options configuration subsystem.

@alnikola alnikola added Type: Enhancement New feature or request Type: Idea This issue is a high-level idea for discussion. labels Oct 22, 2020
@davidfowl
Copy link
Contributor

Right, configuration metadata is a bit of a hack in how it gets manifested as a strongly typed object. We should have a system where configuration metadata is properly represented as a strongly typed object for consumption when various components are manifested.

@samsp-msft samsp-msft changed the title Make *Options configurable through config providers Proxy configuration is extensible for custom metadata on routes, destinations etc Oct 22, 2020
@samsp-msft samsp-msft added the User Story Used for divisional .NET planning label Oct 22, 2020
@karelz karelz added this to the YARP 1.0.0 milestone Nov 10, 2020
@samsp-msft samsp-msft added the Priority:1 Used for divisional .NET planning label Jan 21, 2021
@samsp-msft samsp-msft removed this from the YARP 1.0.0 milestone Oct 8, 2021
@samsp-msft
Copy link
Contributor

Clearing milestone so it can be re-triaged. I am not convinced that this is strictly needed now to be able to ship 1.0

@karelz karelz added this to the Backlog milestone Oct 21, 2021
@samsp-msft
Copy link
Contributor

Duplicate of #1709

@samsp-msft samsp-msft marked this as a duplicate of #1709 May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:1 Used for divisional .NET planning Type: Enhancement New feature or request Type: Idea This issue is a high-level idea for discussion. User Story Used for divisional .NET planning
Projects
None yet
Development

No branches or pull requests

5 participants