Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debug builds from aarch64-unknown-linux-musl.tar.gz #21

Closed
andreamah opened this issue Mar 9, 2023 · 0 comments · Fixed by #22
Closed

Remove debug builds from aarch64-unknown-linux-musl.tar.gz #21

andreamah opened this issue Mar 9, 2023 · 0 comments · Fixed by #22
Assignees
@andreamah
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@andreamah
Copy link
Contributor

andreamah commented Mar 9, 2023 •
edited

For aarch64 linux musl builds, we use cross, which mounts the ripgrep folder as a volume and builds it in a container. Therefore, the changes in #19 don't properly disable debug builds.
@andreamah andreamah added the bug Issue identified by VS Code Team member as probable bug label Mar 9, 2023
@andreamah andreamah self-assigned this Mar 9, 2023
@andreamah andreamah mentioned this issue Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreamah andreamah

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ensure aarch64-unknown-linux-musl gets size optimization flags microsoft/ripgrep-prebuilt
1 participant
@andreamah