Empty RuleParameter is required if there is a rule has undefined identifier in Expression

[kamapcrazy]

Step to reproduce:

• Here is the workflow rules:
  • Noted that the second rule "AvailableIf" contains two more expression identifiers: productStock and customer

[
  {
    "WorkflowName": "DisplayProductAvailability",
    "WorkflowRulesToInject": null,
    "Rules": [
      {
        "RuleName": "AlwaysAvailable",
        "Operator": null,
        "ErrorMessage": "test",
        "ErrorType": "Warning",
        "RuleExpressionType": "LambdaExpression",
        "WorkflowRulesToInject": null,
        "Rules": null,
        "LocalParams": null,
        "Expression": "input.Name == \"Normal product\"",
        "SuccessEvent": null
      },
      {
        "RuleName": "AvailableIf",
        "Operator": "AndAlso",
        "ErrorMessage": "Not Available",
        "ErrorType": "Warning",
        "RuleExpressionType": null,
        "WorkflowRulesToInject": null,
        "Rules": [
          {
            "RuleName": "InStock",
            "Operator": null,
            "ErrorMessage": "Out of stock",
            "ErrorType": "Warning",
            "RuleExpressionType": "LambdaExpression",
            "WorkflowRulesToInject": null,
            "Rules": null,
            "LocalParams": null,
            "Expression": "input.Quantity < productStock.Quantity",
            "SuccessEvent": null
          },
          {
            "RuleName": "VisibleToCustomer",
            "Operator": null,
            "ErrorMessage": "Product is not available at customer location",
            "ErrorType": "Warning",
            "RuleExpressionType": "LambdaExpression",
            "WorkflowRulesToInject": null,
            "Rules": null,
            "LocalParams": null,
            "Expression": "productStock.Location == customer.Location",
            "SuccessEvent": null
          }
        ],
        "LocalParams": null,
        "Expression": null,
        "SuccessEvent": "In stock and visible to customer"
      }
    ]
  }
]

• Execute the workflow with one RuleParameter:

dynamic input = new ExpandoObject();
input.Name = "Normal product";
var ruleParameters = new[]
   {
      new RuleParameter( nameof( input ), input )
   };
RulesEngine.ExecuteRule("DisplayProductAvailability", ruleParameters );

Result: An exception is thrown: "Target object is not an ExpandoObject"
My expection is that the RulesEngine run successfully and the RuleResult should be success for rule name "AlwaysAvailable"

• Execute the workflow with two RuleParameters:

dynamic input = new ExpandoObject();
input.Name = "Normal product";
var ruleParameters = new[]
   {
      new RuleParameter( "empty", "" ), // empty rule parameter and not related to any rules expressions
      new RuleParameter( nameof( input ), input )
   };
RulesEngine.ExecuteRule("DisplayProductAvailability", ruleParameters );

Result: RulesEngine execute successfully, the first rule name is returned "AlwaysAvailable"

[abbasc52]

@kamapcrazy Can you try v2.1.1 and see if this issue still persists?

[abbasc52]

this issue is fixed as a part of 2.1.1, you can refer this test case

RulesEngine/test/RulesEngine.UnitTest/BusinessRuleEngineTest.cs

Lines 220 to 234 in 6b66162

	[Theory]
	[InlineData("rules2.json")]
	public void ExecuteRule_ReturnsProperErrorOnMissingRuleParameter(string ruleFileName)
	{
	var re = GetRulesEngine(ruleFileName);
	var input1 = new RuleParameter("customName",GetInput1());
	var input2 = new RuleParameter("input2",GetInput2());
	var input3 = new RuleParameter("input3",GetInput3());
	List<RuleResultTree> result = re.ExecuteRule("inputWorkflow", input1,input2, input3);
	Assert.NotNull(result);
	Assert.IsType<List<RuleResultTree>>(result);
	Assert.Contains(result.First().ChildResults, c => c.ExceptionMessage.Contains("Unknown identifier 'input1'"));
	}