Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rush] [feature] ability to link specific projects that rush otherwise skipped during install or update #1721

Open
trusktr opened this issue Jan 25, 2020 · 0 comments
Open

[rush] [feature] ability to link specific projects that rush otherwise skipped during install or update #1721

trusktr opened this issue Jan 25, 2020 · 0 comments
Assignees
@Claudiazhaoya
Labels
effort: medium Needs a somewhat experienced developer enhancement The issue is asking for a new feature or design change help wanted If you're looking to contribute, this issue is a good place to start!
Projects
Bug Triage

Comments

@trusktr
Copy link

trusktr commented Jan 25, 2020 •
edited

Rush says

Rush will not locally link code-vue for infamous because the requested version "github:trusktr/live-code" is incompatible with the local version 0.1.0
Rush will not locally link docsify for infamous because the requested version "github:trusktr/docsify#fixes" is incompatible with the local version 4.9.4

This was listed as a bug, but it is now a feature request.

If I'm relying on git refs in package.json (for various reasons like using a forked version of a third-party dependency), how do we link them so we can test changes or similar?

At the moment I use npm link to do it manually, but this is not tracked by Rush.

It may be nice if there was a rush link <project-name> variant of the rush link command which would link a local project (the rush way) into the current project forcefully (for cases when rush otherwise skips the link during rush install or rush update but we still need the link).
@trusktr trusktr changed the title [rush] [bug] In some cases, dependency is linked to downloaded package instead of local project. [rush] [dicussion] how to link packages that use git ref in package.json instead of version number? Jan 27, 2020
@trusktr trusktr closed this as completed Jan 27, 2020
@trusktr trusktr mentioned this issue Jan 27, 2020
Closed
1 task
@trusktr trusktr reopened this Jan 27, 2020
@trusktr trusktr changed the title [rush] [dicussion] how to link packages that use git ref in package.json instead of version number? [rush] [feature] how to link packages that use git ref in package.json instead of version number? Jan 27, 2020
@trusktr trusktr changed the title [rush] [feature] how to link packages that use git ref in package.json instead of version number? [rush] [feature] ability to link specific projects that rush otherwise skipped during install or update Jan 27, 2020
@trusktr trusktr mentioned this issue Jan 28, 2020
Closed
@apostolisms apostolisms added this to Needs Investigation in Bug Triage Jan 29, 2020
@apostolisms apostolisms added effort: medium Needs a somewhat experienced developer enhancement The issue is asking for a new feature or design change help wanted If you're looking to contribute, this issue is a good place to start! labels Jan 29, 2020
@Claudiazhaoya Claudiazhaoya self-assigned this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Claudiazhaoya Claudiazhaoya

Labels
effort: medium Needs a somewhat experienced developer enhancement The issue is asking for a new feature or design change help wanted If you're looking to contribute, this issue is a good place to start!
Projects
Bug Triage
Status: Needs Investigation
Bug Triage
  
Needs Investigation
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trusktr @Claudiazhaoya @apostolisms