Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] upgrade-interactive startup can be slow #3767

Open
elliot-nelson opened this issue Nov 19, 2022 · 1 comment
Open

[rush] upgrade-interactive startup can be slow #3767

elliot-nelson opened this issue Nov 19, 2022 · 1 comment
Assignees
Projects

Comments

@elliot-nelson
Copy link
Collaborator

elliot-nelson commented Nov 19, 2022

Summary

When launching rush upgrade-interactive in a large monorepo on an older MacBook, it took about 15 seconds for the CLI interface to come up.

I was observing via screenshare and the (first-time) user started pressing random keys about 3 seconds in, so I think that's the soft limit for "no output" while loading.

Repro steps

Run upgrade-interactive in a large repo (unclear what that means -- total number of packages, total number of projects, etc.). This particular repo is ~89 projects, ~2700 deps (as reported by rush install).

Details

I think upgrade-interactive can take any amount of time it needs, as long as there's some kind of interactive progress bar, loading spinner, or other output so the user doesn't start spamming ENTERs and CTRL+Cs.

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/rush globally installed version?
rushVersion from rush.json?
useWorkspaces from rush.json?
Operating system?
Would you consider contributing a PR?
Node.js version (node -v)?
@elliot-nelson elliot-nelson changed the title [rush] upgrade-interactive startup is slow [rush] upgrade-interactive startup can be slow Nov 19, 2022
@iclanton
Copy link
Member

@TheLarkInn - Care to take look at this?

@iclanton iclanton added this to In Progress in Bug Triage Nov 21, 2022
@iclanton iclanton moved this from In Progress to Needs Investigation in Bug Triage Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Investigation
Bug Triage
  
Needs Investigation
Development

No branches or pull requests

3 participants