Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SARIF SAST Scans Tab not showing scan results #25

Open
nsid123 opened this issue Nov 1, 2023 · 13 comments · Fixed by #26
Open

SARIF SAST Scans Tab not showing scan results #25

nsid123 opened this issue Nov 1, 2023 · 13 comments · Fixed by #26
Labels
bug Something isn't working

Comments

@nsid123
Copy link

nsid123 commented Nov 1, 2023

Hi I added Microsoft Security DevOps task and installed SARIF SAST Scans Tab. I can see the artifacts that is getting generated with the extension msdo.sarif but i am not seeing any output in the Scans tab. It shows a blank page. Could you please help us on this

@eli-gc
Copy link

eli-gc commented Nov 22, 2023

Having this exact issue as well.

@tmanor2604
Copy link

Hi! I also have the same issue. Though .sarif report is available under CodeAnalysisLogs, 'Scans' tab displays blank page

@Interface007
Copy link

I have the same issue - I've checked that my msdo.sarif is a 5KB json file with 4 "message" nodes. In my case, the issue seems that there are only two empty result-nodes "results": [],. In this case, the tab looks like nothing has been scanned, while the result communicated by Microsoft Security DevOps was: "I have scanned with two tools, but there was no finding." - which is a completely different message than "No results found".

So, for clarity, it may be a good option to indicate on the tab that a scan has been done and what tools did report "No results".

@50Wliu
Copy link
Member

50Wliu commented Dec 29, 2023

@nsid123, @tmanor2604 - are your scans also coming up with 0 results?

@50Wliu 50Wliu added the bug Something isn't working label Dec 29, 2023
@50Wliu
Copy link
Member

50Wliu commented Dec 29, 2023

Also, to make sure we're talking about the same thing when we say "a blank page", screenshots would be helpful!

@50Wliu
Copy link
Member

50Wliu commented Dec 29, 2023

Proposed change for when scans run without returning any results:
Success message showing "No results found after running 1 scan"

@jH-
Copy link

jH- commented Jan 4, 2024

Experiencing this issue in my org's DevOps. Artifacts are generated in the correct location, but the Scans tab is empty (despite results after scanning).

image

No related errors observed in devtools when inspecting the page.
The request you asked to check in the other issue thread (#24 ) does contain the CodeAnalysisLogs item, type: Container.
I also went back and checked some retained pipeline runs from july/august; here the scan tab still display the results.

I haven't been able to pinpoint a change after this that could cause this issue, or seem in any way related.

@50Wliu
Copy link
Member

50Wliu commented Jan 4, 2024

Thanks @jH-. Do those logs also contain results? Or do they come back "clean" (i.e. successfully scanned, but no results to report)?

@jH-
Copy link

jH- commented Jan 5, 2024

@50Wliu They contain results.

@tmanor2604
Copy link

tmanor2604 commented Jan 29, 2024

@nsid123, @tmanor2604 - are your scans also coming up with 0 results?

After I moved SARIF results at the root level of CodeAnalysisLogs, I can view results for a Static Code Analysis tool called Coverity but not from another tool called Astree

@vdkrobby7
Copy link

vdkrobby7 commented Feb 15, 2024

I have the same issue when using a .gdnconfig file for scanning a particular directory.

When I use the generic 'MicrosoftSecurityDevOps@1' task I do get all the scans in both the scan tab and the mdso.sarif file.

Working yaml config:

`pool:
vmImage: 'windows-latest'
trigger:
branches:
include:
- feature/*
steps:

  • task: MicrosoftSecurityDevOps@1
    displayName: 'Microsoft Security DevOps'
    inputs:
    categories: 'IaC'`

Results :

image

image

Not working yaml & gdnconfig config

`trigger: none
pool:
vmImage: 'windows-latest'
steps:

  • task: MicrosoftSecurityDevOps@1
    displayName: 'Microsoft Security DevOps'
    inputs:
    tools: 'TemplateAnalyzer'
    config: pipelines/test-devsecops.gdnconfig
    categories: 'IaC'`

gdnconfig file:
image

Results

image

image

Small remark: it does see that there is an error but does not mark it in red like the task above does.

Is there anything else that needs to be configured somewhere?

@50Wliu
Copy link
Member

50Wliu commented Feb 29, 2024

Reopening because it seems like there's another issue here that needs fixing.

@50Wliu 50Wliu reopened this Feb 29, 2024
@Daholli
Copy link

Daholli commented Apr 11, 2024

I also seem to have issues getting this to display

image

image

Not sure what I am doing wrong

This might have to do with the file ending that is being appended on windows machines but they are still valid sarif files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants