You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The SDK should have a help method that implements the algorithm described in oasis-tcs/sarif-spec#248, "Version control details not strongly associated result", which introduced the property versionControlDetails.mappedTo of type fileLocation.
Since a result can have more than one location, IMO the input to the algorithm should be a FileLocation rather than a Result . We can either implement it in the FileLocation partial class or as an extension method on FileLocation. Since this functionality isn't core to the notion of fileLocation, it feels more like an extension method to me:
public static VersionControlDetails GetRepositoryForFile(
this FileLocation fileLocation,
VersionControlDetails[] versionControlProvenance);
The SDK should have a help method that implements the algorithm described in oasis-tcs/sarif-spec#248, "Version control details not strongly associated result", which introduced the property
versionControlDetails.mappedTo
of typefileLocation
.Since a result can have more than one location, IMO the input to the algorithm should be a
FileLocation
rather than aResult
. We can either implement it in theFileLocation
partial class or as an extension method onFileLocation
. Since this functionality isn't core to the notion offileLocation
, it feels more like an extension method to me:@michaelcfanning FYI
The text was updated successfully, but these errors were encountered: