Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match-results-forward fails in RemapIndicesVisitor #1656

Closed
ghost opened this issue Aug 20, 2019 · 0 comments
Closed

match-results-forward fails in RemapIndicesVisitor #1656

ghost opened this issue Aug 20, 2019 · 0 comments

Comments

@ghost
Copy link

ghost commented Aug 20, 2019

Given a certain pair of files current.sarif and previous.sarif (which I will attach after I have a small, sanitized repro), the command

Sarif.Multitool match-results-forward
    current.sarif --previous previous.sarif --pretty-print --force --output-file-path new.sarif

fails with this exception:

System.ArgumentOutOfRangeException: 'Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index'
   at System.ThrowHelper.ThrowArgumentOutOfRange_IndexException()
   at System.Collections.Generic.List`1.get_Item(Int32 index)
   at Microsoft.CodeAnalysis.Sarif.Visitors.RemapIndicesVisitor.VisitLocation(Location node) in C:\dev\sarif\sarif-sdk\src\Sarif\Visitors\RemapIndicesVisitor.cs:line 60
   at Microsoft.CodeAnalysis.Sarif.SarifRewritingVisitor.VisitActual(ISarifNode node) in C:\dev\sarif\sarif-sdk\src\Sarif\Autogenerated\SarifRewritingVisitor.cs:line 88
   at Microsoft.CodeAnalysis.Sarif.SarifRewritingVisitor.Visit(ISarifNode node) in C:\dev\sarif\sarif-sdk\src\Sarif\Autogenerated\SarifRewritingVisitor.cs:line 28
   at Microsoft.CodeAnalysis.Sarif.SarifRewritingVisitor.VisitNullChecked[T](T node) in C:\dev\sarif\sarif-sdk\src\Sarif\Autogenerated\SarifRewritingVisitor.cs:line 167
   at Microsoft.CodeAnalysis.Sarif.SarifRewritingVisitor.VisitResult(Result node) in C:\dev\sarif\sarif-sdk\src\Sarif\Autogenerated\SarifRewritingVisitor.cs:line 954
   at Microsoft.CodeAnalysis.Sarif.Visitors.RemapIndicesVisitor.VisitResult(Result node) in C:\dev\sarif\sarif-sdk\src\Sarif\Visitors\RemapIndicesVisitor.cs:line 53
   at Microsoft.CodeAnalysis.Sarif.Baseline.ResultMatching.SarifLogResultMatcher.ConstructSarifLogFromMatchedResults(IEnumerable`1 results, IEnumerable`1 previousRuns, IEnumerable`1 currentRuns) in C:\dev\sarif\sarif-sdk\src\Sarif\Baseline\ResultMatching\SarifLogResultMatcher.cs:line 248
   at Microsoft.CodeAnalysis.Sarif.Baseline.ResultMatching.SarifLogResultMatcher.BaselineSarifLogs(IEnumerable`1 previous, IEnumerable`1 current) in C:\dev\sarif\sarif-sdk\src\Sarif\Baseline\ResultMatching\SarifLogResultMatcher.cs:line 136
   at Microsoft.CodeAnalysis.Sarif.Baseline.ResultMatching.SarifLogResultMatcher.Match(IEnumerable`1 previousLogs, IEnumerable`1 currentLogs) in C:\dev\sarif\sarif-sdk\src\Sarif\Baseline\ResultMatching\SarifLogResultMatcher.cs:line 79
   at Microsoft.CodeAnalysis.Sarif.Multitool.ResultMatchingCommand.Run(ResultMatchingOptions matchingOptions) in C:\dev\sarif\sarif-sdk\src\Sarif.Multitool\ResultMatchingCommand.cs:line 52

The offending line is:

if (node.LogicalLocation != null && node.LogicalLocation.Index != -1 && HistoricalLogicalLocations != null)
{
    LogicalLocation logicalLocation = HistoricalLogicalLocations[node.LogicalLocation.Index]; // ERROR
@ghost ghost self-assigned this Aug 20, 2019
@ghost ghost closed this as completed in 9d1da80 Aug 27, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants