Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging gives warning NU5048 #1687

Closed
ghost opened this issue Sep 26, 2019 · 1 comment
Closed

Packaging gives warning NU5048 #1687

ghost opened this issue Sep 26, 2019 · 1 comment
Labels
area-build Issues related to building, packaging, and publishing. bug resolved-fixed

Comments

@ghost
Copy link

ghost commented Sep 26, 2019

We get this warning for each NuGet package we create:

C:\Program Files\dotnet\sdk\3.0.100-preview9-014004\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(198,5):
error NU5048: The 'PackageIconUrl'/'iconUrl' element is deprecated.
Consider using the 'PackageIcon'/'icon' element instead.
Learn more at https://aka.ms/deprecateIconUrl
[C:\dev\sarif\sarif-sdk\src\Sarif.Driver\Sarif.Driver.csproj]

The error message tells the story and the instructions at https://aka.ms/deprecateIconUrl tell how to fix it. We can't refer to the icon through a URL; we need to store it locally and refer to it with the <PackageIcon> element. It turns out we already have a copy of the icon triskelion.png in the repo; we just weren't using it.

See also NuGet/Home#8569

@ghost ghost added bug area-build Issues related to building, packaging, and publishing. labels Sep 26, 2019
@ghost ghost self-assigned this Sep 26, 2019
@ghost
Copy link
Author

ghost commented Sep 26, 2019

@michaelcfanning FYI. I fixed this in the same change as the work I'm doing for #1673.

@ghost ghost changed the title Fix packaging warning NU5048 Packaging gives warning NU5048 Sep 26, 2019
@ghost ghost closed this as completed in 68182f0 Sep 30, 2019
@ghost ghost added the resolved-fixed label Oct 1, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-build Issues related to building, packaging, and publishing. bug resolved-fixed
Projects
None yet
Development

No branches or pull requests

0 participants