AnalyzeCommand base class should handle obsolete ComputeFileHashes arg

[michaelcfanning]

This argument is obsolete in the driver framework, replaced by --insert Hashes. We've marked it as obsolete and it warns on compilation dependency. But I just updated BinSkim to the latest SDK and the driver framework isn't providing backwards compatibility for use of the obsolete arg.

I've added the following code to BinSkim but really it should be in AnalyzeCommand.Run:

#pragma warning disable CS0618 // Type or member is obsolete
            if (analyzeOptions.ComputeFileHashes)
#pragma warning restore CS0618
            {
                OptionallyEmittedData dataToInsert = analyzeOptions.DataToInsert.ToFlags();
                dataToInsert |= OptionallyEmittedData.Hashes;

                analyzeOptions.DataToInsert  = 
                    dataToInsert.ToString().Split('|')
                        .Select(d => { return Enum.Parse<OptionallyEmittedData>(d); })
                        .ToList();

[michaelcfanning]

The framework should also log a notification about the use of the obsolete command, arguable. Minimally, this notification should surface as a warning (and we can elevate to an error in the future to enforce upgrade).

[michaelcfanning]

@eddynaka, good first issue. Maybe for James when he arrives?