Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform (soon to be rewrite) command does not honor --minify #2256

Closed
jameswinkler opened this issue Jan 21, 2021 · 1 comment
Closed

Transform (soon to be rewrite) command does not honor --minify #2256

jameswinkler opened this issue Jan 21, 2021 · 1 comment

Comments

@jameswinkler
Copy link
Collaborator

jameswinkler commented Jan 21, 2021 •
edited

Repro steps:

Using sarif multitool, execute "transform" pointing at \sarif-sdk\src\Test.FunctionalTests.Sarif\v2\ObsoleteFormats\ComprehensivePrereleaseTwoZeroZero.sarif

  • with parameter --minify
  • "--output ComprehensiveReleaseTwoZeroZero.sarif" (for example)

Expected output: a successfully transformed and minified sarif file
Actual output: a successfully transformed but non-minified sarif file

This is likely only when converting from pre-release version 2 to release version 2.
@jameswinkler
Copy link
Collaborator Author

Unable to repro after #2252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jameswinkler