Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SARIF multitool] match-results-forward command removes relevant data from original file #2487

Open
eddynaka opened this issue Jun 15, 2022 · 2 comments
Open

[SARIF multitool] match-results-forward command removes relevant data from original file #2487

eddynaka opened this issue Jun 15, 2022 · 2 comments

Comments

@eddynaka
Copy link
Collaborator

How to simulate:

Use the attached example.zip
and execute the command: sarif match-results-forward .\original.sarif --previous .\previous.sarif -o baselined.sarif --force

Current behavior:

The baselined SARIF does not keep VersionControlProvenance.

Expected behavior:

All relevant data from the original SARIF should be preserved.
@eddynaka
Copy link
Collaborator Author

@marmegh this is one of the issues that I saw when running the E2E pipeline.

@eddynaka eddynaka changed the title [SARIF multitool] match-results-forward removes relevant data from original file [SARIF multitool] match-results-forward command removes relevant data from original file Jun 15, 2022
@marmegh
Copy link
Contributor

marmegh commented Jul 5, 2022

@yongyan-gh, this is one of the issues discussed today.
cc: @EasyRhinoMSFT, @shaopeng-gh

@yongyan-gh yongyan-gh mentioned this issue Jul 20, 2022
Merged
yongyan-gh added a commit that referenced this issue Jul 27, 2022
@yongyan-gh
separate bug fix for #2487 from this PR
9548a62
@yongyan-gh yongyan-gh mentioned this issue Jul 27, 2022
Merged
michaelcfanning pushed a commit that referenced this issue Aug 19, 2022
@yongyan-gh
Fix bug: match-results-forward command generates invalid Sarif (dup…
7dbdf41 
…licated rules). (#2505)

* ResultMatching bug fixes

* Update sub rule check logic

* Addressing PR comments

* Update release history

* separate bug fix for #2487 from this PR

* Update test cases and release note

* Update release note
This was referenced Feb 21, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eddynaka @marmegh