Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not seem to parse artifactLocation.index properly #6

Closed
Tubbles opened this issue Jan 26, 2022 · 2 comments
Closed

Does not seem to parse artifactLocation.index properly #6

Tubbles opened this issue Jan 26, 2022 · 2 comments

Comments

@Tubbles
Copy link

Tubbles commented Jan 26, 2022

I am trying to parse a sarif file which employs the artifactLocation.index in its result listing, which seems to make this tool crash. https://docs.oasis-open.org/sarif/sarif/v2.1.0/os/sarif-v2.1.0-os.html#_Toc34317432 . Please let me know if this tool should be able to parse this syntax and if I might be doing something wrong

@jeffp-seequent
Copy link

I can confirm. Files output from Visual Studio's native code (PREFast) utilize the 'index' field of the artifactLocation. These tools do not parse the 'index' field and instead throw something akin to the following.

ValueError: No location in C6385 output from PREfast

@balgillo
Copy link
Contributor

balgillo commented Sep 8, 2023

I've tested that example in sarif-tools 1.0. After correcting the syntax error "region: { to "region": { in the example JSON, sarif-tools parses the location fine. So, I think this was fixed priori to 1.0 release. Closing issue.

@balgillo balgillo closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants