Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive load testing and run in daily CI #37

Closed
letmaik opened this issue Dec 12, 2022 · 1 comment · Fixed by #138
Closed

Revive load testing and run in daily CI #37

letmaik opened this issue Dec 12, 2022 · 1 comment · Fixed by #138
Assignees
Labels
ci Continuous Integration enhancement New feature or request

Comments

@letmaik
Copy link
Member

letmaik commented Dec 12, 2022

https://github.com/microsoft/scitt-ccf-ledger/tree/main/test/load_test hasn't received much attention in a while and may be broken by now as it's not tested in CI.

The scripts should be checked and a new daily CI (like in CCF) added that runs the load test.

@letmaik letmaik added the enhancement New feature or request label Dec 12, 2022
@letmaik letmaik added the ci Continuous Integration label Dec 20, 2022
@letmaik letmaik self-assigned this Jan 11, 2023
@letmaik
Copy link
Member Author

letmaik commented Jan 11, 2023

I think a good option for this is to use locust as a library (https://docs.locust.io/en/stable/use-as-lib.html). This would allow us to write it as a regular pytest and re-use all the fixtures.
EDIT: From talking to CCF and the comment in the locust docs it is not advisable after all to use it as a library. It may make more sense to use CCF's perf testing library (C++) and run it such that it doesn't wait for commits, essentially trying to cause an overload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant