Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICommunicationListener.CloseAsync not called on replica removed when force-remove=false #118

Open
talarari opened this issue Aug 9, 2018 · 2 comments

Comments

@talarari
Copy link

talarari commented Aug 9, 2018

I'm trying to issue a sfctl replica remove command to gracefully restart my stateless service process.
when using this command:

sfctl replica remove --node-name mynodename --partition-id mypartitionid --replica-id myinstanceid

ICommunicationListener.CloseAsync is not called and instead ICommunicationListener.Abort is called.

when using the force-remove=false flag neither the ICommunicationListener.Abort nor the ICommunicationListener.CloseAsync functions get called.

What is the expected behavior for replica remove with --force-remove=false? what is the default? how can i achieve graceful restart of my stateless service process?

@abhishekram
Copy link

Why are you trying to do this? Is this for testing or some other reason?

@abhishekram
Copy link

Also wanted to add that the behavior you saw is expected.
For graceful restart of your service process, there is no direct command that does it.

One option is to trigger an application upgrade with the --force-restart option, which will result in graceful restart of your processes one upgrade domain at a time. https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-sfctl-application#sfctl-application-upgrade

Please note that you don't necessarily need to update the application version in order to perform an upgrade. You can also do this by updating some application parameter. You could also designate a "dummy" application parameter just for this purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants