Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts between service-fabric-cli and mock #198

Open
NeolithEra opened this issue Aug 3, 2019 · 4 comments
Open

Conflicts between service-fabric-cli and mock #198

NeolithEra opened this issue Aug 3, 2019 · 4 comments

Comments

@NeolithEra
Copy link

Hi, users are unable to run service-fabric-cli due to dependency conflict with mock package.

As shown in the following full dependency graph of service-fabric-cli, service-fabric-cli requires mock,while nose2 0.9.1 requires mock==2.0.0.

According to pip’s “first found wins” installation strategy, mock==3.0.5 is the actually installed version. However, mock==3.0.5 does not satisfy mock==2.0.0.

Dependency tree-------

service-fabric-cli-7.1.0
| +-contextlib2(version range:*)
| +-coverage(version range:*)
| +-jsonpickle(version range:*)
| +-mock(version range:*)
| +-nose2(version range:*)
| | +-six(version range:>=1.7)
| | +-coverage(version range:>=4.4.1)
| | +-mock(version range:==2.0.0;python_version<"3.6")
| +-pylint(version range:*)
| +-python-coveralls(version range:*)
| | +-PyYAML(version range:*)
| | +-requests(version range:*)
| | | +-chardet(version range:>=3.0.2,<3.1.0)
| | | +-idna(version range:>=2.5,<2.9)
| | | +-urllib3(version range:>=1.21.1,<1.26)
| | | +-certifi(version range:>=2017.4.17)
| | +-coverage(version range:*)
| | +-six(version range:*)
| +-vcrpy(version range:*)

Thanks for your help.
Best,
Neolith

@NeolithEra
Copy link
Author

Fix your direct dependency to be mock==2.0.0.
I have checked this revision will not affect your downstream projects now.

@Christina-Kang May I pull a request to fix this issue?

@jeffj6123
Copy link
Member

@NeolithEra what install instructions are you using to get SFCTL?

@NeolithEra
Copy link
Author

NeolithEra commented Aug 16, 2019

@jeffj6123 We use pip install -r requirement.txt to intall service-fabric-cli,
as we are planning to do some secondary development and function expanding.

@Christina-Kang
Copy link
Contributor

@NeolithEra Gotcha! If you already have a fix for this on your branch, we would very much appreciate a PR! :) If not, we will push a fix through with our next update (provided this issue is non blocking for you, which it seems not to be).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants