Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UploadApplicationPackageAsync to IApplicationTypeClient #4

Closed
aL3891 opened this issue May 23, 2018 · 4 comments
Closed

Move UploadApplicationPackageAsync to IApplicationTypeClient #4

aL3891 opened this issue May 23, 2018 · 4 comments

Comments

@aL3891
Copy link
Contributor

aL3891 commented May 23, 2018

Is there a particular reason UploadApplicationPackageAsync IApplicationTypeClient is in IApplicationClient and not IApplicationTypeClient? It feels more related to application types than application instances, but perhaps that's just my gut feeling

@amanbha
Copy link
Contributor

amanbha commented May 23, 2018

@aL3891 UploadApplicationPackage ties more logically with Applications. An Applications' package is uploaded and not ApplciationType's package. Can be debated either ways, will keep it open for more feedback, if majority of people feel this way then it can be moved.,

@aL3891
Copy link
Contributor Author

aL3891 commented May 23, 2018

I'd argue that you are in fact uploading an application type version, not an application. After it's uploaded you need to provision it and then create an actual application, using this method does not result in an application being created or manipulated in any way.

It's a matter of taste i suppose, but it seems more consistent to have it on the ApplicationType or even ImageStore interface, rather then the Application

@amanbha
Copy link
Contributor

amanbha commented May 23, 2018

@aL3891 ImageStore makes sense for this as its uploading to image store.

@amanbha
Copy link
Contributor

amanbha commented Jun 8, 2018

PR #12 addressed this, method moved to IImageStoreClient

@amanbha amanbha closed this as completed Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants