-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move UploadApplicationPackageAsync to IApplicationTypeClient #4
Comments
@aL3891 UploadApplicationPackage ties more logically with Applications. An Applications' package is uploaded and not ApplciationType's package. Can be debated either ways, will keep it open for more feedback, if majority of people feel this way then it can be moved., |
I'd argue that you are in fact uploading an application type version, not an application. After it's uploaded you need to provision it and then create an actual application, using this method does not result in an application being created or manipulated in any way. It's a matter of taste i suppose, but it seems more consistent to have it on the ApplicationType or even ImageStore interface, rather then the Application |
@aL3891 ImageStore makes sense for this as its uploading to image store. |
PR #12 addressed this, method moved to IImageStoreClient |
Is there a particular reason UploadApplicationPackageAsync IApplicationTypeClient is in IApplicationClient and not IApplicationTypeClient? It feels more related to application types than application instances, but perhaps that's just my gut feeling
The text was updated successfully, but these errors were encountered: