Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Concurrent monitoring: CPU data deletion mistiming can lead to no results. #266

Closed
GitTorre opened this issue Mar 14, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@GitTorre
Copy link
Member

GitTorre commented Mar 14, 2023

Bug Details

Scope

This issue applies to AppObserver, and only when AppObserverEnableConcurrentMonitoring is enabled, and you are monitoring several services (which is the only reason you would enable concurrent monitoring on capable hardware).

Problem

Random occurrences of FabricResourceUsageData.Data containers not containing any items for CPU data. This is not consistent or frequent but can take place due to a data clearing bug in ObserverBase.ProcessResourceDataReportHealth.

Solution

Until 3.2.6 ships, if you experience this often, disable AppObserverEnableConcurrentMonitoring configuration in ApplicationManifest.xml.

The easiest solution for you for now, if you build the code yourself, is to replace the data.ClearData() call at the end of the ObserverBase.ProcessResourceDataReportHealth function with

if (ObserverName != ObserverConstants.AppObserverName) 
{
     data.ClearData();
}
@GitTorre GitTorre added the bug Something isn't working label Mar 14, 2023
@GitTorre GitTorre self-assigned this Mar 14, 2023
@GitTorre GitTorre added this to the 3.2.6 milestone Mar 14, 2023
@GitTorre
Copy link
Member Author

Fix is in develop branch.

@GitTorre
Copy link
Member Author

Fix Shipped in 3.2.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant