Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info on "Windows Update" setting #59

Closed
ChiragPavecha opened this issue Sep 17, 2019 · 11 comments · Fixed by #63
Closed

Info on "Windows Update" setting #59

ChiragPavecha opened this issue Sep 17, 2019 · 11 comments · Fixed by #63
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ChiragPavecha
Copy link

Would be great if we can add Banner/Warning/Link to clusters where Windows Update is still enabled and potentially causing VM’s to reboot unexpectedly. Link in banner pointing to recommended SF configuration for VMSS OS Updates or POA

@jeffj6123
Copy link
Member

So I feel like there are a few scenarios we would need to be able to handle for this to work and expose as an API:

  • What would we do for linux cluster
  • How would this work for on prem clusters

I feel that this would actually be a prime place for SF Observer. @GitTorre would this be pretty straight forward to implement as an observer?

@sridmad
Copy link
Member

sridmad commented May 2, 2020

Agree. Fabric Observer is a better tool to surface this information.

@sridmad sridmad transferred this issue from microsoft/service-fabric-explorer May 2, 2020
@GitTorre
Copy link
Member

GitTorre commented May 2, 2020

Thanks for the feature request. Yes, this is something that OSObserver could look for and, if detected, emit an informational health event that contains a link to related documentation much as it does today with links to kb articles about OS updates/patches that have been installed on the VM it's running on. This information would also reside in the structured telemetry data OSO emits.

@GitTorre GitTorre self-assigned this May 2, 2020
@GitTorre GitTorre added the enhancement New feature or request label May 2, 2020
@GitTorre
Copy link
Member

GitTorre commented May 2, 2020

How about this?

CaptureAUFO

@sridmad
Copy link
Member

sridmad commented May 2, 2020

May be create a different health event specifically for Windows Updates related information so they can be marked as warning and/or error as the case may be.

Auto Windows update enabled should always be a warning in SF scenarios - Use automatic Image update or POA (for bronze durability)

Warnings if OS updates are not installed after a grace period?

@GitTorre
Copy link
Member

GitTorre commented May 2, 2020

@sridmad Yes, if it should be a warning, then OSO will generate one if AU service is enabled.

In terms of OS update grace period expiration warnings, that should really be something POA does, as it is already configurable for that type of thing, for example. I'm not sure FO should join the WU game. For stuff like AU detection, that's easy. For monitoring updates, generally, this will add redundancy if POA is installed. FO doesn't orchestrate patching and as such warning users that an update must take place due to some configurable (?) grace period expiration makes more sense in a service that does.

AU enabled Warning, which will take place on each node:

CaptureAUFO

@GitTorre
Copy link
Member

GitTorre commented May 2, 2020

Pushed change to develop. It's not ready for merge into master (code refinement/refactoring/review, more testing). You can pull latest from there and test it out. I will merge into master and produce signed builds early next week. Let me know what you think.

If you can think of more OS-level configurations/settings/services to monitor, please create a new Issue. Thanks again for filing this one.

@GitTorre GitTorre modified the milestones: 5.0.3, 2.0.6 May 4, 2020
@GitTorre
Copy link
Member

GitTorre commented May 4, 2020

Pull latest from develop. The first impl was too aggressive.

@GitTorre
Copy link
Member

GitTorre commented May 5, 2020

CaptureAUFO

@GitTorre GitTorre linked a pull request May 7, 2020 that will close this issue
@GitTorre GitTorre closed this as completed May 7, 2020
@markwragg
Copy link

markwragg commented May 7, 2020

I think this should be reopened. Currently the code does the following check for if Windows Updates are enabled (which is if the service is enabled then the setting must be "notify before download"):

   this.isWindowsUpdateAutoDownloadEnabled =
                    wuLibAutoUpdates.ServiceEnabled &&
                    wuLibAutoUpdates.Settings.NotificationLevel != AutomaticUpdatesNotificationLevel.aunlNotifyBeforeDownload;

In my environment, the service is enabled but Windows Update is set to "never check for updates". I think the above check should be amended to include that as an acceptable sign that Windows updates are disabled (the enum to check I believe would be AutomaticUpdatesNotificationLevel.aunlDisabled).

Note also that I set virtualMachineProfile.osProfile.windowsConfiguration.enableAutomaticUpdates to false in the ARM template as per the guide on VMSS automatic OS image upgrades and this still didn't end up putting Windows Update in a state where it was disabled for my environment (even for new nodes that were created after the change). Although its worth noting that we have a boot script that sets auto updates to "never check for updates" in the registry so maybe this has overridden the default setting that this ARM property sets. I was surprised it didn't disable the Windows Update service tbh.

@markwragg
Copy link

Created a new issue for this as I think it makes more sense/easier to relate to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants