Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash when parse delay load table in 32bit dll #40

Closed
darknesswind opened this issue Apr 10, 2024 · 4 comments · Fixed by #41
Closed

crash when parse delay load table in 32bit dll #40

darknesswind opened this issue Apr 10, 2024 · 4 comments · Fixed by #41

Comments

@darknesswind
Copy link

darknesswind commented Apr 10, 2024

src/SizeBench.AnalysisEngine/PE/PEFile.cs : 511
thunk32 deref twice (use nameTableThunkRva) but only once (use nameTableThunkPtrRva) need

delayLoad.zip

Tasks

No tasks being tracked yet.
@Austin-Lamb
Copy link
Collaborator

Is there a 32-bit DLL I can try this on to repro? If you don't have anything publicly shareable but can share privately, let me know and we can figure that out.

@darknesswind
Copy link
Author

Is there a 32-bit DLL I can try this on to repro? If you don't have anything publicly shareable but can share privately, let me know and we can figure that out.

I Uploaded the demo

@Austin-Lamb
Copy link
Collaborator

I can repro this locally, I'm working on a fix - thank you for providing the repro!

@Austin-Lamb
Copy link
Collaborator

🎉 @darknesswind, the fixed version is now deployed to the Store now.

You may need to go into the Store app and click "get updates" to force it to update immediately. The fixed version is 2.2404.1801.0

Thank you for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants