Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back off strategy for large reservations #224

Closed
mjp41 opened this issue Jul 5, 2020 · 2 comments
Closed

Add back off strategy for large reservations #224

mjp41 opened this issue Jul 5, 2020 · 2 comments
Assignees

Comments

@mjp41
Copy link
Member

mjp41 commented Jul 5, 2020

In the POSIX and Windows PALs, if aligned allocation isn't provided we reserve a large amount of memory, so that we can perform alignment work in the AddressSpaceManager. However, if the large reservation fails, then the system will determine out-of-memory.

The PALs should attempt to reduce the size of reservation in the failure case, so that the program can continue working if possible.

@SchrodingerZhu
Copy link
Contributor

I see. I mentioned this at #223 because it is somehow related to the allocation overhead, but now I can understand the true reason is behind this reservation behavior.

@mjp41
Copy link
Member Author

mjp41 commented Jul 5, 2020

@SchrodingerZhu thanks for your investigation into the other issue, and report this finding. It is important to get this right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants