Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samlp:Extensions should be placed after Issuer tag #36

Closed
fume opened this issue Sep 7, 2022 · 0 comments · Fixed by #37
Closed

samlp:Extensions should be placed after Issuer tag #36

fume opened this issue Sep 7, 2022 · 0 comments · Fixed by #37
Labels
bug Something isn't working

Comments

@fume
Copy link
Collaborator

fume commented Sep 7, 2022 •
edited

SAMLRequest schema dictates to have the Extensions tag right after the Signature, hence we must add it after the Issuer tag.

The code to change is here:

SPID-and-Digital-Identity-Enabler/WebApps/Proxy/Microsoft.SPID.Proxy/Models/Extensions/RequestSAMLAsXMLExtensions.cs

Line 175 in ada2d5f

rootEl.AppendChild(Extensions);

Instead of appending the Extensions to rootEl, we should InsertAfter the Issuer tag, which we should retrieve.
@fume fume added the bug Something isn't working label Sep 7, 2022
@fume fume linked a pull request Sep 7, 2022 that will close this issue
Insert Extensions after Issuer #37
Merged
@fume fume mentioned this issue Sep 7, 2022
Merged
@fume fume closed this as completed in #37 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Insert Extensions after Issuer microsoft/SPID-and-Digital-Identity-Enabler
1 participant
@fume