Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos and Suggested Wording #36

Closed
jamiere-msft opened this issue May 2, 2019 · 1 comment
Closed

Typos and Suggested Wording #36

jamiere-msft opened this issue May 2, 2019 · 1 comment

Comments

@jamiere-msft
Copy link

jamiere-msft commented May 2, 2019

Overall, the usage of "." after sentences is inconsistent. Section 1.0 had most sentences ending with a period while 0.0 did not.

In the README.MD file

  • The second link under About this Workshop has the word "Architecture" misspelled
  • "This README.MD file explains how the workshop is laid out, what you will learn" might be better phrased "This README.MD file explains how the workshop is structured, what you will learn"
    0.0 Prerequisites
  • "It does have an assumption to know basics of using a Linux bash shell but all commands are provided to run the activities including scripts." could be rephrased as "It does assume basic knowledge of using a Linux bash shell, though all commands are provided to run the activities including scripts."
  • In the activities list, why does it have both bullets and numbers? Maybe indent the 1-6 software required steps and use a different bullet.

Activity:Prerequisites

Activity: Deploy SQL Server on OpenShift

@rgward
Copy link
Member

rgward commented May 3, 2019

Jamie, I addressed almost all of the issues here. In some cases, Buck had done a bit of wordsmith and reformatting which made the comment no longer applicable.

@rgward rgward closed this as completed May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants