Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog documentation should be replaced with only officials docs #22

Closed
mbcrump opened this issue Mar 15, 2017 · 6 comments
Closed

blog documentation should be replaced with only officials docs #22

mbcrump opened this issue Mar 15, 2017 · 6 comments
Assignees
Labels
enhancement Indicates the issue is a suggestion for an improvement or alteration to something that already exist help wanted Issues where external contributors are wanted to help address the issue.
Milestone

Comments

@mbcrump
Copy link
Contributor

mbcrump commented Mar 15, 2017

ToastNotificationService.cs and probably others

        //TODO UWPTemplates: Handle activation from toast notification,
        //for more info handling activation see
        //https://blogs.msdn.microsoft.com/tiles_and_toasts/2015/07/08/quickstart-sending-a-local-toast-notification-and-handling-activations-from-it-windows-10/
@mbcrump mbcrump added the enhancement Indicates the issue is a suggestion for an improvement or alteration to something that already exist label Mar 15, 2017
@ralarcon
Copy link
Contributor

@crutkas @mbcrump We used this as reference but we need to sync all together to decide what is preferred.

@crutkas
Copy link
Member

crutkas commented Mar 22, 2017

Docs when 100% possible, else defer to blog. for this example that Crump referenced, does https://docs.microsoft.com/en-us/windows/uwp/controls-and-patterns/tiles-and-notifications-adaptive-interactive-toasts handle it?

@crutkas crutkas added this to the 1.0 milestone Mar 22, 2017
@crutkas
Copy link
Member

crutkas commented Apr 6, 2017

Crump, we need to just do a full walk down of everything now that Codebehind is added.

@crutkas crutkas added the help wanted Issues where external contributors are wanted to help address the issue. label Apr 6, 2017
@crutkas
Copy link
Member

crutkas commented Apr 6, 2017

Community, thinking this would be a great item for everyone to look at. be sure the documentation makes sense.

@mrlacey
Copy link
Collaborator

mrlacey commented Apr 7, 2017

Having a look now and will raise individual issues but as a general point.
Comments should have a space between the delimiter (//) and the start of the comment.

It's not mentioned explicitly in our code guidelines but is covered in the C# Coding Conventions on MSDN (snippet below.)

Commenting Conventions

  • Place the comment on a separate line, not at the end of a line of code.
  • Begin comment text with an uppercase letter.
  • End comment text with a period.
  • Insert one space between the comment delimiter (//) and the comment text, as shown in the following example.
    // The following declaration creates a query. It does not run
    // the query.
  • Do not create formatted blocks of asterisks around comments.

@crutkas
Copy link
Member

crutkas commented Apr 10, 2017

Went through and did a bunch of work on this.
514eba4
ff467ad
94dceaa

I think as is, this is a vague issue and should also be closed out w/ actionable, new bugs

@crutkas crutkas closed this as completed Apr 10, 2017
sibille pushed a commit to sibille/WindowsTemplateStudio that referenced this issue Jan 27, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Indicates the issue is a suggestion for an improvement or alteration to something that already exist help wanted Issues where external contributors are wanted to help address the issue.
Projects
None yet
Development

No branches or pull requests

4 participants