Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top of window border loses color after focus mode/full-screen #10052

Closed
vefatica opened this issue May 7, 2021 · 5 comments
Closed

Top of window border loses color after focus mode/full-screen #10052

vefatica opened this issue May 7, 2021 · 5 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Milestone

Comments

@vefatica
Copy link

vefatica commented May 7, 2021

Windows Terminal version (or Windows build number)

WindowsTerminal: 1.8.1092.0

Other Software

No response

Steps to reproduce

  1. Enable a keystroke for toggling focus mode; e.g., {"command": "toggleFocusMode", "keys": "shift+f11"},
  2. Enter focus mode (tabs and title hidden)
  3. Go to full-screen (Alt+Enter)
  4. Return from full-screen (Alt+Enter)
  5. Left-click the desktop
  6. Left-click in WT

Expected Behavior

WT's border (accent color) should be intact.

Actual Behavior

After steps 5 and 6, WT has lost the accent color of its top border ...

Normal (magenta-ish accent):
image
After step 5 (window inactive):
image
After step 6 (window active):
image

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 7, 2021
@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label May 10, 2021
@zadjii-msft
Copy link
Member

Meh, I could have sworn there was a dupe for this.

Oh nevermind, the "dupe" was

KNOWN ISSUE: Upon resizing the NCIW, the top frame margin disappears, making that border disappear entirely. 6356aaf has a bunch of WIP work for me trying to fix that, but I couldn't get it quite right.

in #6804.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) labels May 11, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 11, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone May 11, 2021
@marbaa
Copy link

marbaa commented May 12, 2021

Windows 10 has few years old bug that top border of any window has different color than the rest of borders. Maybe it is affecting here Terminal as well.

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 13, 2021
@zadjii-msft
Copy link
Member

You know what, this might just be one of those things that's "fixed in Windows 11". I can't get this to repro any longer - I'm guessing with all the DWM work they've done, they fixed the root cause.

It'd be neigh impossible to track down which change was the individual one that did it, and I'd reckon it'd be similarly impossible for us to backport the fix to win10, considering the breadth of DWM changes.

@zadjii-msft zadjii-msft added the Resolution-Fix-Available It's available in an Insiders build or a release label Aug 18, 2021
@vefatica
Copy link
Author

vefatica commented Jan 4, 2022

I can no longer reproduce it using

Microsoft Windows 10 Pro for Workstations
10.0.19044.1415 (2009, 21H2)
Windows Terminal Preview 1.12.3472.0

@vefatica
Copy link
Author

vefatica commented Jan 4, 2022

And I CAN reproduce it with

Microsoft Windows 10 Pro for Workstations
10.0.19044.1415 (2009, 21H2)
Windows Terminal 1.11.3471.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Projects
None yet
Development

No branches or pull requests

4 participants