Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIA in conhost: incorrect word boundaries when text is selected #11809

Open
Tracked by #5800
codeofdusk opened this issue Nov 23, 2021 · 10 comments
Open
Tracked by #5800

UIA in conhost: incorrect word boundaries when text is selected #11809

codeofdusk opened this issue Nov 23, 2021 · 10 comments
Labels
Area-Accessibility Issues related to accessibility Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Conhost For issues in the Console codebase
Milestone
Backlog

Comments

@codeofdusk
Copy link
Contributor

Windows Terminal version

Version of OpenConsole included with the wt 1.12 release.

Windows build number

10.0.22000.348

Other Software

NVDA master (2022.1) with UIA.

Steps to reproduce

Paste the following text into a conhost. On my system, this line wraps at the word "upgrade":

tree.IncompatibleFormatError: This file is too new for the currently running version of Treemendous (0.0.0). Please upgrade to Treemendous 42.0.0 or later.

Then:

  • Select a word, such as by moving to the top of the console and searching for the word "please" with CTRL+f.
  • navigate forward in the window by word.

Expected Behavior

word boundaries are correctly calculated: after the wrapping, NVDA says "upgrade", "to", "Treemendous", etc.

Actual Behavior

NVDA reads from the start of the line up to some arbitrary point, can't tell what's going on???
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 23, 2021
@codeofdusk
Copy link
Contributor Author

This does not repro in wt.

CC @carlos-zamora, @DHowett.

@codeofdusk codeofdusk reopened this Dec 5, 2021
@codeofdusk
Copy link
Contributor Author

Confirmed repro of this issue in FORMATTED conhost, but looks like this is the only remaining word boundary bug!

@codeofdusk
Copy link
Contributor Author

codeofdusk commented Dec 5, 2021 •
edited
Loading

On further testing, it is important that the selected text must be on a line that wraps, and the selection must be somewhere on that line. NVDA+f9/f10 also works for selection here (not just CTRL+f), so I presume the mouse would as well.

@codeofdusk codeofdusk mentioned this issue Dec 5, 2021
Merged
@zadjii-msft
Copy link
Member

This might be related to #5800, or some of the weird line wrapping bugs that I've at least been linking up to that one. I'm thinking particularly the #6901, #10833, #11739 subset.

@zadjii-msft zadjii-msft added Area-Accessibility Issues related to accessibility Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Conhost For issues in the Console codebase labels Dec 6, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 6, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Dec 6, 2021
@zadjii-msft zadjii-msft mentioned this issue Dec 6, 2021
Open
31 tasks
@codeofdusk
Copy link
Contributor Author

@zadjii-msft This bug explicitly doesn't repro in wt (conhost only). Please re-label.

@zadjii-msft
Copy link
Member

.... pretty sure I only added the conhost label...
image
image

@codeofdusk
Copy link
Contributor Author

codeofdusk commented Dec 6, 2021 •
edited
Loading

Can't see image but it says you added it to the terminal v2.0 milestone. Should be in 22H1 or whichever milestone tracks the new conhost version post-undocking.

@zadjii-msft
Copy link
Member

zadjii-msft commented Dec 6, 2021 •
edited
Loading

Ah. I've been kinda re-thinking how we track milestones for our issues recently, since the Windows-specific ones don't totally make sense and have been pretty loosely tracked, and there's not really a difference between the Terminal and Console backlogs anymore. I suppose for the time being, I'll slap that into the 22H1 milestone, but we might be shaking those up in the future, FYI.

Oh hmm we don't even have a 22H1 milestone, but that makes sense, there isn't a 22H1 milestone internally...

@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H1 Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H1, Terminal v1.14 Feb 2, 2022
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 14, 2022
@zadjii-msft zadjii-msft modified the milestones: Terminal v1.14, 22H2 Apr 28, 2022
@codeofdusk
Copy link
Contributor Author

FYI this repros in the SV2 inbox console. CC @carlos-zamora, @DHowett.

@zadjii-msft zadjii-msft added the Needs-Discussion Something that requires a team discussion before we can proceed label May 2, 2022
@zadjii-msft
Copy link
Member

@codeofdusk Yep, looks like this one didn't make it in unfortunately. Hopefully we'll get a chance for the next release.

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. and removed Needs-Discussion Something that requires a team discussion before we can proceed labels May 3, 2022
@zadjii-msft zadjii-msft mentioned this issue Nov 8, 2022
Closed
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@DHowett @codeofdusk @zadjii-msft