Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure caption controls "dim out" when window loses NC focus (WM_NCACTIVATE?) #12632

Open
Tracked by #3327
Poopooracoocoo opened this issue Mar 6, 2022 · 5 comments
Labels
Area-Theming Anything related to the theming of elements of the window Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@Poopooracoocoo
Copy link

Poopooracoocoo commented Mar 6, 2022

Windows Terminal version

1.13.10395.0

Windows build number

10.0.19044

Other Software

No response

Steps to reproduce

  1. Open Windows Terminal
  2. Click outside of window to lose focus and make the window inactive

Expected Behavior

Current tab would go grey
Caption buttons would go grey

Actual Behavior

Neither titlebar element go grey

@Poopooracoocoo Poopooracoocoo added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Mar 6, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 6, 2022
@zadjii-msft
Copy link
Member

zadjii-msft commented Mar 7, 2022

Generally, I've been duping these to #4862. However, I totally missed the one other checkbox in #1625 about the caption button colors, so I'm gonna re-purpose this issue to track that element. Thanks!

Note

Walkthrough

To do this, we'd need to:

  • Listen for a WM_NCACTIVATE in IslandWindow
  • Plumb that as an event up to AppHost
  • Call a new method on AppLogic, which plumbs that down to TerminalPage to tell them that the window was activated/inactivated
  • in TerminalPage, when _settings.GlobalSettings().ShowTabsInTitlebar() is true, call to MinMaxCloseControl in TitlebarControl to tell it the window is no longer active
  • There, change the color of the buttons when the window is activated/deactivated.

See also #10401, which never got finished.

@zadjii-msft zadjii-msft changed the title Window looks the same when active and inactive Make sure caption controls "dim out" when window loses NC focus (WM_NCACTIVATE?) Mar 7, 2022
@zadjii-msft zadjii-msft added good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Mar 7, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Mar 7, 2022
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 8, 2022
@Poopooracoocoo
Copy link
Author

I'm psyched to see that #4862 was implemented. Is this still being worked on?

@zadjii-msft
Copy link
Member

zadjii-msft commented Sep 14, 2022

Is this still being worked on?

Not currently, but it seems fairly trivial these days. The plumbing in #4862 should make it trivial.

proposed "schema":

captionButtons: {
  foreground: ThemeColor,
  background: ThemeColor (default: #00000000),
  unfocusedForeground: ThemeColor,
  unfocusedBackground: ThemeColor (default: #00000000),
}

I don't really think we need to have separate knobs for each of the buttons.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Area-Theming Anything related to the theming of elements of the window labels Sep 14, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 14, 2022
@jamespack
Copy link
Contributor

I may take a stab at this one if that is ok.

@zadjii-msft
Copy link
Member

@jamespack Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Theming Anything related to the theming of elements of the window Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
Status: Walkthrough in issue
Development

No branches or pull requests

4 participants