Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persistedWindowLayout does not work as expected on 1.12.10393.0 #12684

Closed
scaramushe opened this issue Mar 13, 2022 · 4 comments
Closed

persistedWindowLayout does not work as expected on 1.12.10393.0 #12684

scaramushe opened this issue Mar 13, 2022 · 4 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@scaramushe
Copy link

Windows Terminal version

1.12.10393.0

Windows build number

10.0.22000.0

Other Software

No response

Steps to reproduce

Following guidelines in
https://docs.microsoft.com/en-us/windows/terminal/customize-settings/startup#behavior-when-starting-a-new-terminal-session :

Add the following line to the settings file:
"firstWindowPreference": "persistedWindowLayout",
Settings file: C:\Users\[User Name]\AppData\Local\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState\settings.json - attached at txt
settings.txt

  • Create some custom window state (multiple tabs and panes with different names)
  • Close the app using the "X" button or "Alt-F4" combination
  • Open the app again

Expected Behavior

Open last set of panes and tabs as before closing

Actual Behavior

Open single tab and pane

@scaramushe scaramushe added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Mar 13, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 13, 2022
@Rosefield
Copy link
Contributor

One guess, do you use the quake window? The logic is that on first start (i.e. no terminals running) it will load the saved state, but of course if you have a hidden quake window open it won't reload state. If you want to make sure that all of the windows are closed there is the quit action that will close all open terminal windows and save all of their layouts.

@Rosefield
Copy link
Contributor

On second thought, it is probably that this feature is not enabled on stable builds yet (just terminal preview). A future release will enable for stable builds. #12422

@scaramushe
Copy link
Author

Thanks for the reply!
Indeed this is available only in preview, verified that it works with 1.13.10395.0 - current preview version available on winget
Thanks a lot, closing.

@scaramushe
Copy link
Author

One thought - perhaps the documentation should state that this is available only in preview
Opened MicrosoftDocs/terminal#521 to reflect that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

2 participants