Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[profiles] What should I do to actually delete these profiles? #13451

Closed
Tracked by #6800
NekoAria opened this issue Jul 7, 2022 · 7 comments
Closed
Tracked by #6800

[profiles] What should I do to actually delete these profiles? #13451

NekoAria opened this issue Jul 7, 2022 · 7 comments
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.

Comments

@NekoAria
Copy link

NekoAria commented Jul 7, 2022

Windows Terminal version

1.13.11431.0

Windows build number

10.0.19043.0

Other Software

No response

Steps to reproduce

After I delete these profiles, and reopen the wt, and going to add a new profile, I find they are still existing.

Expected Behavior

These profiles are actually deleted.

Actual Behavior

These profiles are still existing.

@NekoAria NekoAria added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 7, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 7, 2022
@NekoAria NekoAria changed the title [profiles] I want to actually delete this profiles, what should I do? [profiles] I want to actually delete these profiles, what should I do? Jul 7, 2022
@NekoAria NekoAria changed the title [profiles] I want to actually delete these profiles, what should I do? [profiles] What should I do to actually delete these profiles? Jul 7, 2022
@zadjii-msft
Copy link
Member

Did you hit Save after deleting them? Could you share your settings.json file/?

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 7, 2022
@NekoAria
Copy link
Author

NekoAria commented Jul 7, 2022

Did you hit Save after deleting them? Could you share your settings.json file/?

Yes.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jul 7, 2022
@NekoAria
Copy link
Author

NekoAria commented Jul 7, 2022

{
    "$help": "https://aka.ms/terminal-documentation",
    "$schema": "https://aka.ms/terminal-profiles-schema",
    "actions": 
    [
        {
            "command": 
            {
                "action": "copy",
                "singleLine": false
            },
            "keys": "ctrl+c"
        },
        {
            "command": "paste",
            "keys": "ctrl+v"
        },
        {
            "command": "find",
            "keys": "ctrl+shift+f"
        },
        {
            "command": 
            {
                "action": "splitPane",
                "split": "auto",
                "splitMode": "duplicate"
            },
            "keys": "alt+shift+d"
        }
    ],
    "copyFormatting": "none",
    "copyOnSelect": false,
    "defaultProfile": "{f33743eb-6e3b-4d53-8a1e-59a6a567b47c}",
    "profiles": 
    {
        "defaults": 
        {
            "colorScheme": "MaterialOcean",
            "cursorShape": "filledBox",
            "font": 
            {
                "face": "\u66f4\u7eb1\u9ed1\u4f53 Mono SC Nerd"
            }
        },
        "list": 
        [
            {
                "colorScheme": "MaterialOcean",
                "commandline": "",
                "guid": "{f33743eb-6e3b-4d53-8a1e-59a6a567b47c}",
                "hidden": false,
                "icon": "D:\\fish.gif",
                "name": "fish",
                "startingDirectory": "%USERPROFILE%"
            },
            {
                "colorScheme": "MaterialOcean",
                "guid": "{aab79973-318f-43b6-a9bc-b4096493753f}",
                "hidden": false,
                "name": "Nushell",
                "source": "nu"
            },
            {
                "colorScheme": "MaterialOcean",
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "hidden": false,
                "name": "Windows PowerShell"
            },
            {
                "colorScheme": "MaterialOcean",
                "commandline": "",
                "guid": "{02d5718b-5b02-4dda-9430-87d047c90533}",
                "hidden": false,
                "icon": "ms-appx:///ProfileIcons/{b453ae62-4e3d-5e58-b989-0a998ec441b8}.png",
                "name": ""
            },
            {
                "colorScheme": "MaterialOcean",
                "commandline": "",
                "guid": "{49f5f541-e2cf-4c7c-8ca8-9dfa0b2717fb}",
                "icon": "ms-appx:///ProfileIcons/{b453ae62-4e3d-5e58-b989-0a998ec441b8}.png",
                "name": ""
            }
        ]
    },
    "schemes": [],
    "tabSwitcherMode": "mru"
}

@NekoAria
Copy link
Author

NekoAria commented Jul 7, 2022

I withheld some information on privacy reasons.

@zadjii-msft
Copy link
Member

Hmm. Looks like deleted profiles still show up in the duplicate profile dropdown. That's wild, and sure shouldn't be happening.

Yep, the AddProfile page is just handed a whole reference to the settings, and doesn't filter on !IsDeleted(), like the other nav view does.

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. Priority-3 A description (P3) Area-Settings UI Anything specific to the SUI and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Jul 7, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.16 milestone Jul 7, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 7, 2022
@zadjii-msft zadjii-msft added Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 7, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 7, 2022
@DHowett
Copy link
Member

DHowett commented Jul 7, 2022

Ah, so deleted profiles are intended to show up in that dropdown. Until we have support for "template" profiles (like, "Terminal detected these -- do you want one of them?"), we have to store them there. Otherwise, there is no way to get them back, for users who have changed their minds.

@zadjii-msft
Copy link
Member

That's fine by me. I'm gonna call this "by design" then. Maybe not the most clear, but not a bug. If anyone's got good recommendations on ways to make this clearer, feel free to add it in the comments below.

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Jul 7, 2022
@zadjii-msft zadjii-msft added the Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. label Jul 7, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.
Projects
None yet
Development

No branches or pull requests

3 participants