Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to open settings (profiles.json): ShellExecute in LaunchSettings returns ERROR_ACCESS_DENIED #1381

Closed
brettfo opened this issue Jun 22, 2019 · 2 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@brettfo
Copy link
Member

brettfo commented Jun 22, 2019

Environment

Windows build number: 10.0.18362.175 (1903)
Windows Terminal version (if applicable): 0.2.1715.0

Any other software? No

Steps to reproduce

Open the settings file, either through the UI or via Ctrl+,

Expected behavior

The settings file to open.

Actual behavior

Nothing visible happens.

I built and debugged locally from the 0.2.1715.0 sources (66cb7c4) and found that ShellExecute in LaunchSettings was returning 5 (ERROR_ACCESS_DENIED according to winerror.h, line 265). The value of settingsPath was properly formed (C:\Users\brettfo\AppData\Local\Packages\WindowsTerminalDev_<some-garbage-characters>\RoamingState\profiles.json) and the file exists on disk with the expected contents.

I also found the settings file corresponding to the app installed from the Store at C:\Users\brettfo\AppData\Local\Packages\Microsoft.WindowsTerminal_<some-garbage-characters>\RoamingState\profiles.json which is also correct and changed settings are appropriately reflected in the app.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 22, 2019
@mithunshanbhag
Copy link

mithunshanbhag commented Jun 22, 2019

I too am facing the same issue. Please take a look at the attached screen capture gif below.

Some additional details:

  1. Windows Terminal (preview) version 0.2.1715.0. Downloaded from the Microsoft Store.
  2. This issue also repro'es for me when I build the windows terminal's github sources locally and launch the CascadiaPackage.
  3. The issue still repro'es even if I run the terminal as an elevated admin.
  4. Window Insider Build: 10.0.18922.1000 (fast-ring)
  5. I'm running Windows 10 on Macbook Air (4 proc, 8 GB RAM).
  6. As a workaround, I'm able to tweak the profile.json file manually and configure the settings.

Please let me know if I can provide any additional details.

microsoft-terminal-issue

@DHowett-MSFT
Copy link
Contributor

I accidentally made #1460 the master issue for this, so.. here goes!

@DHowett-MSFT DHowett-MSFT added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. labels Jun 24, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 24, 2019
@DHowett-MSFT DHowett-MSFT added Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 24, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants