Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the scroll bar is thicker than normal when the cursor hovers it #13842

Open
unuing opened this issue Aug 25, 2022 · 9 comments
Open

the scroll bar is thicker than normal when the cursor hovers it #13842

unuing opened this issue Aug 25, 2022 · 9 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@unuing
Copy link

unuing commented Aug 25, 2022

Windows Terminal version

1.15.2284.0

Windows build number

10.0.25188.1000

Other Software

No response

Steps to reproduce

just open windows terminal and input some command or press enter until the scroll bar appears

Expected Behavior

the normal scroll bar looks like this:
image

Actual Behavior

the scroll bar is too thick:
image

@unuing unuing added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Aug 25, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 25, 2022
@zadjii-msft
Copy link
Member

Are they actually different widths/? Or is the thumb just slightly less rounded?

When we initially moved to Controlsv2 the scrollbar was actually wider, but we should have forced it back to the typical width. If it's wider for you, then this might be the inverse of #13361

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 25, 2022
@unuing
Copy link
Author

unuing commented Aug 25, 2022

Are they actually different widths/? Or is the thumb just slightly less rounded?

they actually has different widths. the thicker one is about double width of the normal one.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 25, 2022
@zadjii-msft
Copy link
Member

Really? That's weird. In your screenshots, the first is 22px, the second is 24px. That's weird that their different at all tbh.

What DPI scaling is your screen set to?

@unuing
Copy link
Author

unuing commented Aug 25, 2022

Really? That's weird. In your screenshots, the first is 22px, the second is 24px. That's weird that their different at all tbh.

I'm using windows's snipping tool to create that screenshot, instead of prtsc key, maybe the image is compressed.

What DPI scaling is your screen set to?

image
Sorry if the Chinese UI is confusing.

@unuing unuing changed the title the scroll bar looks thicker than normal when the cursor is above it the scroll bar looks thicker than normal when the cursor hovers it Aug 25, 2022
@unuing
Copy link
Author

unuing commented Aug 25, 2022

a comparison:

image
this is windows terminal's scroll bar

image
this is a normal one

the blue lines has the same widths.

@unuing
Copy link
Author

unuing commented Aug 26, 2022

I see the same thing in #13361 (comment). I bet it is also thicker than normal.

@unuing unuing changed the title the scroll bar looks thicker than normal when the cursor hovers it the scroll bar is thicker than normal when the cursor hovers it Aug 26, 2022
@unuing
Copy link
Author

unuing commented Aug 26, 2022

To add here, the scroll bar is normal in settings UI.

@ghost
Copy link

ghost commented Aug 26, 2022

At fault is the WinUI scrollbar template, which works in a confusing way.
To customize the space around the thumb you need to change ScrollBarThumbStrokeThickness to 2x the expected padding.

In this case you want 5px, so you would set it to 10:
image

Unfortunately, this will also affect the thumb in minimal mode:
image

Normally you'd want to be able to set the width for each state, but it's not really possible currently.

@zadjii-msft
Copy link
Member

I'll stick this on the backlog, but it's blocked on the upstream microsoft/microsoft-ui-xaml#7682.

@zadjii-msft zadjii-msft added this to the Icebox ❄ milestone Feb 14, 2023
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-3 A description (P3) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Attention The core contributors need to come back around and look at this ASAP. labels Feb 14, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants