Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAWS] Mark mode reads the next character instead of the one that's selected #14151

Open
carlos-zamora opened this issue Oct 6, 2022 · 1 comment
Assignees
Labels
Area-Accessibility Issues related to accessibility Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone

Comments

@carlos-zamora
Copy link
Member

Windows Terminal version

1.16.2642

Windows build number

No response

Other Software

JAWS

Steps to reproduce

  1. have output (echo test)
  2. enter mark mode
  3. move to first "t" in test"
  4. move right one cell (onto "e")

Expected Behavior

the newly selected text/letter should be read ("e")

Actual Behavior

the letter beside it is read ("s")

@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. labels Oct 6, 2022
@carlos-zamora carlos-zamora added this to the Terminal v1.17 milestone Oct 6, 2022
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 6, 2022
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 6, 2022
@zadjii-msft zadjii-msft added the Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) label Dec 19, 2022
@carlos-zamora carlos-zamora self-assigned this Jan 11, 2023
@carlos-zamora
Copy link
Member Author

Issue repros with JAWS 2023.2212.23.

I took a look at this and I'm seeing A LOT of events from JAWS, so that makes it a bit difficult to track. Uploading here so that I don't have to do it again.

TVPP Session.csv

GetSelection() is operating as expected, along with the other UIA APIs, it seems. I'm betting that this is another manifestation of #13447. So I'm suspecting JAWS gets the selection changed event and does a bunch of UIA calls to figure out what to present. At the end of the day, it ends up presenting the wrong character.

Only thing I can suggest here is that JAWS either changes their implementation or we see if this gets fixed alongside #13447. And unfortunately, if JAWS changes their implementation, there's no promise that it'll still work when #13447 is fixed.

I'm keeping this open but I don't think there's much we can do here (at least in the short-term).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Issues related to accessibility Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants