Crash when opening a new tab or window, or any non-default profile

[sboukortt]

Windows Terminal version

1.18.1421.0

Windows build number

10.0.19045.0

Other Software

No response

Steps to reproduce

Open two tabs or two windows.

Expected Behavior

Two tabs are opened and can be used.

Actual Behavior

Opening the second tab or window triggers a crash of the entire application, taking both tabs/windows with it.

Windows Terminal 1.16.10261.0 with the same configuration works as expected.

[sboukortt]

I saw an open issue that I thought might be related but the discussion suggests that that other issue is specific to when focusFollowMouse is enabled, and I have it disabled.

[lhecker]

Yesterday, when running a debug build off of main, I also had it crashing, and it was due to GetRootPane() returning nullptr right here:

terminal/src/cascadia/TerminalApp/TerminalPage.cpp

Lines 3355 to 3360 in 3c3b1aa

	terminalTab->GetRootPane()->WalkTree([&](auto&& pane) {
	if (auto control = pane->GetTerminalControl())
	{
	control.WindowVisibilityChanged(showOrHide);
	}
	});

Curiously this issue has never occurred before on my PC.

[sboukortt]

Oh, interesting, thanks. Is it something that would be reasonably easy to bisect?

[lhecker]

It's not really something that needs to be bisected, because as far as I can tell, the exact same code ran perfectly fine for the last year on my PC. Rather, I suspect that some unrelated change has changed the order of initialization slightly to allow for visibility change messages to arrive sooner. This could've for instance happened, because I made the startup of Windows Terminal vastly (>2x) faster.
Although we'll only know if you're victim of the same issue if you either debug Windows Terminal yourself (for instance via WinDbg; you can find it in the App Store) or capture a crash dump for us (see here). Otherwise, we'll automatically receive minidumps of this crash within a week or so, if you have telemetry enabled.

[zadjii-msft]

Yea, we'll need a stack or something to investigate here.

If you file /feedback with the Feedback Hub, we might be able to reverse engineer that in the backend and find crashes that have already happened. Unlikely, but worth a shot.

If it repros consistently though, then just trying to repro it with the feedback hub's "Recreate my problem" recorder should grab the dump.

[microsoft-github-policy-service]

Hi there!

Can you please send us feedback with the Feedback Hub with this issue? Make sure to click the "Start recording" button, then reproduce the issue before submitting the feedback. Once it's submitted, paste the link here so we can more easily find your crash information on the back end?

Thanks!

[dziban303]

Same thing is happening for me. Normally it's intermittent—usually, I can open a new tab without issue. I'd say that the issue manifests maybe 20% of the time. Luckily, it happened every single time when recording it with Feedback Hub, a Vorführeffekt in my favor for a change 😂

[zadjii-msft]

@dziban303 can you share the Feedback Hub link here?

[dziban303]

Hey @zadjii-msft sorry. Here's the link https://aka.ms/AAkzyij

[zadjii-msft]

I won't be able to take a look till tomorrow at the earliest, but as a sanity check, does https://github.com/microsoft/terminal/releases/tag/v1.18.1462.0 work? That has some hotfixes for... kinda a lot of bugs...

[dziban303]

Thanks, it was literally installing via the Store when you sent that. I'll give it a whirl later tonight. Cheers

[sboukortt]

Sadly, it still reproduces for me. It also seems not to always respect the window transparency I have set, and it crashes when going to “Settings” -> (“Profiles” ->) “Defaults” -> “Appearance” where one would set it. Could that be related?

I tried to file feedback with the Feedback Hub but couldn’t quite figure out whether it would record crash data for Terminal Preview if I select “Terminal” as the app (Terminal Preview isn’t offered as a choice). Does it?

[zadjii-msft]

Okay so ai was able to find a dump from @dziban303's machine (even if Feedback Hub wasn't the most cooperative). It looks like you're hitting the "focusFollowMouse": true crash. That was tracked in #15412, and should be fixed in https://github.com/microsoft/terminal/releases/tag/v1.18.1462.0.

@sboukortt - you've got that setting disabled, so presumably you're seeing something new. Can you file the same Feedback Hub steps above/? That should help us find the dump on the backend.

[sboukortt]

I am not sure what changed but it doesn’t seem to be happening anymore? That’s still with v1.18.1462.0.

The main change I can think of that could possibly have to do with this is that I upgraded my graphics driver (NVIDIA) to 535.98, from the previous “studio” driver (I don’t remember which version that was).

[DHowett]

Wow, okay, that's weird. Since we lost our repro, I'm gonna close this one out. Please don't hesitate to yell at us if it comes back!

[sboukortt]

For some reason, it seems to be happening again since my last reboot. (I usually use hybrid shutdown / “fast startup” rather than a full reboot.) The version of Terminal Preview is still v1.18.1462.0.

I am getting the impression that there is something that causes it to either happen reliably or not at all after every reboot, which is rather mysterious. Thankfully, if that is the case, it means I have until my next full reboot to figure out how to get a proper stacktrace.

[sboukortt]

I still haven’t gotten around to doing that, but for what it’s worth, the other day, I updated my GPU driver and it seems to have crashed Terminal Preview but not Terminal.

[zhangjy859]

Hi @sboukortt，

I also have the same issue after a system reboot, Could you please give me some suggestions? I have feedback with feedback hub

[zadjii-msft]

@zhangjy859 Do you have MacType installed by any chance? If so, go update it. Older versions of that will crash the Terminal.

If not, could you share the link to your feedback in Feedback Hub here in this thread? Thanks!

[zhangjy859]

@zhangjy859 Do you have MacType installed by any chance? If so, go update it. Older versions of that will crash the Terminal.

If not, could you share the link to your feedback in Feedback Hub here in this thread? Thanks!

Yeah, I have MacType, I have tried update it and uninstall it, but not work, however, as @sboukortt's comment, I updated my GPU graphic driver, Its ok.

Interestingly, this is my workstation and for a considerable amount of time, it had a fixed version of Windows Terminal, MacType, and graphics drivers, and they worked without any issues. I'm not sure why there was a change after a restart. In any case, updating the graphics drivers could be helpful.

Thank you for your prompt reply and assistance.