Remove SetWrapForced from AdaptDispatch::_WriteToBuffer #15602
Labels
Area-Output
Related to output processing (inserting text into buffer, retrieving buffer text, etc.)
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Product-Conpty
For console issues specifically related to conpty
Milestone
From what I understand, a row should only be marked as force-wrapped if we actually wrote past the last column, which naturally occurs already in the
AdaptDispatch::_DoLineFeed
call.Removing the
SetWrapForced
call however breaks these unit tests:They break because when a
ROW
is not marked as force-wrapped the output behavior of the VtEngine and its output changes. We need to investigate why they break, what the correct behavior should be and how we can fix it. Presumably most unit tests simply assert the wrong behavior, but it's also possible thatVtEngine::_PaintUtf8BufferLine
and itsremoveSpaces
variable may have to be updated.The text was updated successfully, but these errors were encountered: